2003-02-24 18:26:57

by Maciej Soltysiak

Subject: [PATCH] extern in sleep.c

Hi,

there's a following warning in 2.5.62-bk7:

arch/i386/kernel/acpi/sleep.c: In function `acpi_restore_state_mem':
arch/i386/kernel/acpi/sleep.c:62: warning: implicit declaration of
function `zap_low_mappings'

Here's an extern to cover it:

--- linux-2.5.60/arch/i386/kernel/acpi/sleep.c~ 2003-02-18 17:48:18.000000000 +0100
+++ linux-2.5.60/arch/i386/kernel/acpi/sleep.c 2003-02-24 19:13:20.000000000 +0100
@@ -8,6 +8,7 @@
#include <linux/bootmem.h>
#include <asm/smp.h>

+extern void zap_low_mappings (void);

/* address in low memory of the wakeup routine. */
unsigned long acpi_wakeup_address = 0;

2003-02-24 18:27:42

by Maciej Soltysiak

Subject: [PATCH] extern in i2o_pci.c

Hi,

there's a following warning in 2.5.62-bk7:

drivers/message/i2o/i2o_pci.c: In function `i2o_pci_core_attach':
drivers/message/i2o/i2o_pci.c:373: warning: implicit declaration of
function `i2o_sys_init'

The following patch covers the extern.

--- linux-2.5.60/drivers/message/i2o/i2o_pci.c~ 2003-02-24 19:31:41.000000000 +0100
+++ linux-2.5.60/drivers/message/i2o/i2o_pci.c 2003-02-24 19:30:04.000000000 +0100
@@ -37,6 +37,7 @@
#endif // CONFIG_MTRR

static int dpt;
+extern void i2o_sys_init(void);

/**
* i2o_pci_dispose - Free bus specific resources

2003-02-24 18:46:45

by Alan

Subject: Re: [PATCH] extern in i2o_pci.c

On Mon, 2003-02-24 at 18:36, Maciej Soltysiak wrote:
> Hi,
>
> there's a following warning in 2.5.62-bk7:
>
> drivers/message/i2o/i2o_pci.c: In function `i2o_pci_core_attach':
> drivers/message/i2o/i2o_pci.c:373: warning: implicit declaration of
> function `i2o_sys_init'

Yep.. i2o_pci needs folding into i2o_core. No non PCI i2o ever happened so its
a spare abstraction