2006-10-10 16:58:04

by Jiri Kosina

[permalink] [raw]
Subject: [PATCH] drivers/net/irda/donauboe.c broken in current git tree

Hi Jeff,

your commit c31f28e778ab299a5035ea2bda64f245b8915d7c (which currently is
in mainline) broke drivers/net/irda/donauboe.c, as it removes
toshoboe_invalid_dev(), but this is called from toshoboe_interrupt()
(your patch removed reference to it only from toshoboe_probeinterrupt().

I guess the fix below is appropriate .. ?

Signed-off-by: Jiri Kosina <[email protected]>

diff --git a/drivers/net/irda/donauboe.c b/drivers/net/irda/donauboe.c
index 636d063..14cc217 100644
--- a/drivers/net/irda/donauboe.c
+++ b/drivers/net/irda/donauboe.c
@@ -1158,9 +1158,6 @@ toshoboe_interrupt (int irq, void *dev_i
__u8 irqstat;
struct sk_buff *skb = NULL;

- if (self == NULL && toshoboe_invalid_dev(irq))
- return IRQ_NONE;
-
irqstat = INB (OBOE_ISR);

/* was it us */

--
Jiri Kosina