2008-01-08 21:20:42

by Rik van Riel

Subject: [patch 08/19] add newly swapped in pages to the inactive list

Swapin_readahead can read in a lot of data that the processes in
memory never need. Adding swap cache pages to the inactive list
prevents them from putting too much pressure on the working set.

This has the potential to help the programs that are already in
memory, but it could also be a disadvantage to processes that
are trying to get swapped in.

In short, this patch needs testing.

Signed-off-by: Rik van Riel <[email protected]>

Index: linux-2.6.24-rc6-mm1/mm/swap_state.c
===================================================================
--- linux-2.6.24-rc6-mm1.orig/mm/swap_state.c 2008-01-02 12:37:38.000000000 -0500
+++ linux-2.6.24-rc6-mm1/mm/swap_state.c 2008-01-02 12:37:52.000000000 -0500
@@ -300,7 +300,7 @@ struct page *read_swap_cache_async(swp_e
/*
* Initiate read into locked page and return.
*/
- lru_cache_add_active_anon(new_page);
+ lru_cache_add_anon(new_page);
swap_readpage(NULL, new_page);
return new_page;
}

--
All Rights Reversed

2008-01-08 22:28:30

by Christoph Lameter

Subject: Re: [patch 08/19] add newly swapped in pages to the inactive list

On Tue, 8 Jan 2008, Rik van Riel wrote:

> In short, this patch needs testing.

Seems to be a good idea.

Reviewed-by: Christoph Lameter <[email protected]>