2008-02-13 21:43:32

by Adrian Bunk

[permalink] [raw]
Subject: [2.6 patch] make slub.c:slab_address() static

slab_address() can become static.

Signed-off-by: Adrian Bunk <[email protected]>

---
fdd710f00d8bed8413c160685bc5229ec15b4d9f diff --git a/mm/slub.c b/mm/slub.c
index e2989ae..af83daf 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -308,7 +308,7 @@ static inline int is_end(void *addr)
return (unsigned long)addr & PAGE_MAPPING_ANON;
}

-void *slab_address(struct page *page)
+static void *slab_address(struct page *page)
{
return page->end - PAGE_MAPPING_ANON;
}


2008-02-13 21:57:57

by Pekka Enberg

[permalink] [raw]
Subject: Re: [2.6 patch] make slub.c:slab_address() static

Adrian Bunk wrote:
> slab_address() can become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
> fdd710f00d8bed8413c160685bc5229ec15b4d9f diff --git a/mm/slub.c b/mm/slub.c
> index e2989ae..af83daf 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -308,7 +308,7 @@ static inline int is_end(void *addr)
> return (unsigned long)addr & PAGE_MAPPING_ANON;
> }
>
> -void *slab_address(struct page *page)
> +static void *slab_address(struct page *page)
> {
> return page->end - PAGE_MAPPING_ANON;
> }
>

Acked-by: Pekka Enberg <[email protected]>

2008-02-13 22:21:33

by Christoph Lameter

[permalink] [raw]
Subject: Re: [2.6 patch] make slub.c:slab_address() static

Queued-by: Christoph Lameter <[email protected]>

On Wed, 13 Feb 2008, Adrian Bunk wrote:

> slab_address() can become static.
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
> fdd710f00d8bed8413c160685bc5229ec15b4d9f diff --git a/mm/slub.c b/mm/slub.c
> index e2989ae..af83daf 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -308,7 +308,7 @@ static inline int is_end(void *addr)
> return (unsigned long)addr & PAGE_MAPPING_ANON;
> }
>
> -void *slab_address(struct page *page)
> +static void *slab_address(struct page *page)
> {
> return page->end - PAGE_MAPPING_ANON;
> }
>
>