2008-08-20 02:46:34

by Mike Frysinger

Subject: [PATCH] linux/timex.h: cleanup for userspace

MAXFREQ_SCALED was tweaked recently to contain a (s64) cast. Assuming this
is meant for userspace, change it to (__s64) and pull in linux/types.h.

Signed-off-by: Mike Frysinger <[email protected]>
---
include/linux/timex.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/linux/timex.h b/include/linux/timex.h
index fc6035d..07ed536 100644
--- a/include/linux/timex.h
+++ b/include/linux/timex.h
@@ -55,6 +55,7 @@

#include <linux/compiler.h>
#include <linux/time.h>
+#include <linux/types.h>

#include <asm/param.h>

@@ -88,7 +89,7 @@

#define MAXPHASE 500000000l /* max phase error (ns) */
#define MAXFREQ 500000 /* max frequency error (ns/s) */
-#define MAXFREQ_SCALED ((s64)MAXFREQ << NTP_SCALE_SHIFT)
+#define MAXFREQ_SCALED ((__s64)MAXFREQ << NTP_SCALE_SHIFT)
#define MINSEC 256 /* min interval between updates (s) */
#define MAXSEC 2048 /* max interval between updates (s) */
#define NTP_PHASE_LIMIT ((MAXPHASE / NSEC_PER_USEC) << 5) /* beyond max. dispersion */
--
1.5.6.1

2008-08-21 03:10:32

by Roman Zippel

Subject: Re: [PATCH] linux/timex.h: cleanup for userspace

Hi,

On Tue, 19 Aug 2008, Mike Frysinger wrote:

> MAXFREQ_SCALED was tweaked recently to contain a (s64) cast. Assuming this
> is meant for userspace, change it to (__s64) and pull in linux/types.h.

No, it's irrelevant for user space.
Most of it can be moved down into the __KERNEL__ block.
Look at the glibc timex.h for what is currently exported.

bye, Roman