2009-06-05 14:30:49

by Minchan Kim

Subject: [PATCH][mmtom] remove annotation of gfp_mask in add_to_swap

Hugh removed add_to_swap's gfp_mask argument.
(mm: remove gfp_mask from add_to_swap)
So we have to remove annotation of gfp_mask of the function.

This patch cleans up add_to_swap function.
It doesn't affect behavior of function.

Signed-off-by: Minchan Kim <[email protected]>
Cc: Hugh Dickins <[email protected]>
---
mm/swap_state.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/swap_state.c b/mm/swap_state.c
index b9ca029..b62e7f5 100644
--- a/mm/swap_state.c
+++ b/mm/swap_state.c
@@ -124,7 +124,6 @@ void __delete_from_swap_cache(struct page *page)
/**
* add_to_swap - allocate swap space for a page
* @page: page we want to move to swap
- * @gfp_mask: memory allocation flags
*
* Allocate swap space for the page and add the page to the
* swap cache. Caller needs to hold the page lock.
--
1.5.6.5

2009-06-05 18:20:14

by Hugh Dickins

Subject: Re: [PATCH][mmtom] remove annotation of gfp_mask in add_to_swap

On Fri, 5 Jun 2009, Minchan Kim wrote:

> Hugh removed add_to_swap's gfp_mask argument.
> (mm: remove gfp_mask from add_to_swap)
> So we have to remove annotation of gfp_mask of the function.

"annotation"? Or "DocBook comment"? Or "DocBook annotation"?

>
> This patch cleans up add_to_swap function.
> It doesn't affect behavior of function.
>
> Signed-off-by: Minchan Kim <[email protected]>
> Cc: Hugh Dickins <[email protected]>

Thanks, yes, my oversight.

Acked-by: Hugh Dickins <[email protected]>

> ---
> mm/swap_state.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/mm/swap_state.c b/mm/swap_state.c
> index b9ca029..b62e7f5 100644
> --- a/mm/swap_state.c
> +++ b/mm/swap_state.c
> @@ -124,7 +124,6 @@ void __delete_from_swap_cache(struct page *page)
> /**
> * add_to_swap - allocate swap space for a page
> * @page: page we want to move to swap
> - * @gfp_mask: memory allocation flags
> *
> * Allocate swap space for the page and add the page to the
> * swap cache. Caller needs to hold the page lock.
> --
> 1.5.6.5