2002-09-21 20:12:37

by Adrian Bunk

[permalink] [raw]
Subject: [2.5 patch] fix .text.exit error in tdfxfb.c

Hi James,

Burton Samograd reported a .text.exit error at the final linking in
2.5.37. The problem is that tdfxfb_remove is __devexit but the pointer to
the function didn't use __devexit_p. The following patch fixes it:


--- linux-2.5.37/drivers/video/tdfxfb.c.old 2002-09-21 22:06:55.000000000 +0200
+++ linux-2.5.37/drivers/video/tdfxfb.c 2002-09-21 22:07:47.000000000 +0200
@@ -146,7 +146,7 @@
.name = "tdfxfb",
.id_table = tdfxfb_id_table,
.probe = tdfxfb_probe,
- .remove = tdfxfb_remove,
+ .remove = __devexit_p(tdfxfb_remove),
};

MODULE_DEVICE_TABLE(pci, tdfxfb_id_table);


cu
Adrian

--

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
Alan Cox



2002-09-21 20:24:50

by Burton Samograd

[permalink] [raw]
Subject: Re: [2.5 patch] fix .text.exit error in tdfxfb.c

On Sat, Sep 21, 2002 at 10:17:36PM +0200, Adrian Bunk wrote:
> Hi James,
>
> Burton Samograd reported a .text.exit error at the final linking in
> 2.5.37. The problem is that tdfxfb_remove is __devexit but the pointer to
> the function didn't use __devexit_p. The following patch fixes it:
>

Thanks james, that fixed the build...now lets see if it runs :)

burton


Attachments:
(No filename) (366.00 B)
(No filename) (189.00 B)
Download all attachments