2022-03-22 09:04:48

by Nava kishore Manne

Subject: [PATCH v2 4/5] fpga: Use tab instead of spaces for indentation

Trivial fix.

Signed-off-by: Nava kishore Manne <[email protected]>
---
Changes for v2:
-None.

drivers/fpga/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile
index 0bff783d1b61..5935b3d0abd5 100644
--- a/drivers/fpga/Makefile
+++ b/drivers/fpga/Makefile
@@ -18,9 +18,9 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o
obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o
obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o
-obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o
-obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o
-obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o
+obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o
+obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o
+obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o

# FPGA Bridge Drivers
obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o
--
2.25.1

2022-03-27 23:38:44

by Tom Rix

Subject: Re: [PATCH v2 4/5] fpga: Use tab instead of spaces for indentation

On 3/22/22 1:22 AM, Nava kishore Manne wrote:
> Trivial fix.

This is not descriptive.

Improve the commit log to explain the issue and solution.

Tom

>
> Signed-off-by: Nava kishore Manne <[email protected]>
> ---
> Changes for v2:
> -None.
>
> drivers/fpga/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile
> index 0bff783d1b61..5935b3d0abd5 100644
> --- a/drivers/fpga/Makefile
> +++ b/drivers/fpga/Makefile
> @@ -18,9 +18,9 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o
> obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o
> obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o
> obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o
> -obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o
> -obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o
> -obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o
> +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o
> +obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o
> +obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o
>
> # FPGA Bridge Drivers
> obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o

2022-04-03 16:34:32

by Nava kishore Manne

Subject: RE: [PATCH v2 4/5] fpga: Use tab instead of spaces for indentation

Hi Tom,

Thanks for providing the review comments.
Please find my response inline.

> -----Original Message-----
> From: Tom Rix <[email protected]>
> Sent: Saturday, March 26, 2022 10:39 PM
> To: Nava kishore Manne <[email protected]>; [email protected];
> [email protected]; [email protected]; Michal Simek
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]; git
> <[email protected]>
> Subject: Re: [PATCH v2 4/5] fpga: Use tab instead of spaces for indentation
>
>
> On 3/22/22 1:22 AM, Nava kishore Manne wrote:
> > Trivial fix.
>
> This is not descriptive.
>
> Improve the commit log to explain the issue and solution.
>
I Will update the commit message in v3.

Regards,
Navakishore.