2020-06-09 09:55:27

by Hui Song

Subject: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.

From: Song Hui <[email protected]>

delete the interrupt IRQF_NO_THREAD flags.

Signed-off-by: Song Hui <[email protected]>
---
drivers/gpio/gpio-mpc8xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 604dfec..1e86652 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -417,7 +417,7 @@ static int mpc8xxx_probe(struct platform_device *pdev)

ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn,
mpc8xxx_gpio_irq_cascade,
- IRQF_NO_THREAD | IRQF_SHARED, "gpio-cascade",
+ IRQF_SHARED, "gpio-cascade",
mpc8xxx_gc);
if (ret) {
dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d), ret = %d\n",
--
2.9.5

2020-06-09 20:40:14

by Leo Li

Subject: RE: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.

> -----Original Message-----
> From: Hui Song <[email protected]>
> Sent: Tuesday, June 9, 2020 4:38 AM
> To: [email protected]; Shawn Guo <[email protected]>;
> Leo Li <[email protected]>; Rob Herring <[email protected]>; Mark
> Rutland <[email protected]>; Linus Walleij <[email protected]>;
> Bartosz Golaszewski <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; Hui Song
> <[email protected]>
> Subject: [PATCH] gpio: mpc8xxx: change the gpio interrupt flags.
>
> From: Song Hui <[email protected]>
>
> delete the interrupt IRQF_NO_THREAD flags.

I think this is the correct direction but would be better to describe a little bit on what motived this change. Any issue encountered or latency optimization?

>
> Signed-off-by: Song Hui <[email protected]>
> ---
> drivers/gpio/gpio-mpc8xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index
> 604dfec..1e86652 100644
> --- a/drivers/gpio/gpio-mpc8xxx.c
> +++ b/drivers/gpio/gpio-mpc8xxx.c
> @@ -417,7 +417,7 @@ static int mpc8xxx_probe(struct platform_device
> *pdev)
>
> ret = devm_request_irq(&pdev->dev, mpc8xxx_gc->irqn,
> mpc8xxx_gpio_irq_cascade,
> - IRQF_NO_THREAD | IRQF_SHARED, "gpio-
> cascade",
> + IRQF_SHARED, "gpio-cascade",
> mpc8xxx_gc);
> if (ret) {
> dev_err(&pdev->dev, "%s: failed to devm_request_irq(%d),
> ret = %d\n",
> --
> 2.9.5