Add support for the LS1028a PCIe controller.
Signed-off-by: Xiaowei Bao <[email protected]>
Signed-off-by: Hou Zhiqiang <[email protected]>
---
v2:
- No change.
v3:
- Reuse the ls2088 driver data structurt.
v4:
- No change.
v5:
- No change.
v6:
- No change.
drivers/pci/controller/dwc/pci-layerscape.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index 3a5fa26..f24f79a 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata = {
static const struct of_device_id ls_pcie_of_match[] = {
{ .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
+ { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
{ .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
--
2.9.5
On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> Add support for the LS1028a PCIe controller.
>
> Signed-off-by: Xiaowei Bao <[email protected]>
> Signed-off-by: Hou Zhiqiang <[email protected]>
> ---
> v2:
> - No change.
> v3:
> - Reuse the ls2088 driver data structurt.
> v4:
> - No change.
> v5:
> - No change.
> v6:
> - No change.
>
> drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> index 3a5fa26..f24f79a 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata = {
> static const struct of_device_id ls_pcie_of_match[] = {
> { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
I think you can save this driver change by using "fsl,ls2088a-pcie" as
compatible fallback like below.
compatible = "fsl,ls1028a-pcie", "fsl,ls2088a-pcie";
Shawn
> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> --
> 2.9.5
>
> -----Original Message-----
> From: Shawn Guo <[email protected]>
> Sent: 2019??10??3?? 17:11
> To: Xiaowei Bao <[email protected]>
> Cc: [email protected]; [email protected]; Leo Li
> <[email protected]>; M.h. Lian <[email protected]>; Mingkai Hu
> <[email protected]>; Roy Zang <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; Z.q. Hou <[email protected]>
> Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
>
> On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> > Add support for the LS1028a PCIe controller.
> >
> > Signed-off-by: Xiaowei Bao <[email protected]>
> > Signed-off-by: Hou Zhiqiang <[email protected]>
> > ---
> > v2:
> > - No change.
> > v3:
> > - Reuse the ls2088 driver data structurt.
> > v4:
> > - No change.
> > v5:
> > - No change.
> > v6:
> > - No change.
> >
> > drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c
> > b/drivers/pci/controller/dwc/pci-layerscape.c
> > index 3a5fa26..f24f79a 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata
> > = { static const struct of_device_id ls_pcie_of_match[] = {
> > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
>
> I think you can save this driver change by using "fsl,ls2088a-pcie" as
> compatible fallback like below.
>
> compatible = "fsl,ls1028a-pcie", "fsl,ls2088a-pcie";
Yes, it is ok to do so, but according to the previous code, I think add a new compatible " fsl,ls1028a-pcie " to driver is better.
Thanks
Xiaowei
>
> Shawn
>
> > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> > --
> > 2.9.5
> >
On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> Add support for the LS1028a PCIe controller.
>
> Signed-off-by: Xiaowei Bao <[email protected]>
> Signed-off-by: Hou Zhiqiang <[email protected]>
> ---
> v2:
> - No change.
> v3:
> - Reuse the ls2088 driver data structurt.
> v4:
> - No change.
> v5:
> - No change.
> v6:
> - No change.
>
> drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> index 3a5fa26..f24f79a 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata = {
> static const struct of_device_id ls_pcie_of_match[] = {
> { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
Reviewed-by: Andrew Murray <[email protected]>
> --
> 2.9.5
>
On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> Add support for the LS1028a PCIe controller.
>
> Signed-off-by: Xiaowei Bao <[email protected]>
> Signed-off-by: Hou Zhiqiang <[email protected]>
> ---
> v2:
> - No change.
> v3:
> - Reuse the ls2088 driver data structurt.
> v4:
> - No change.
> v5:
> - No change.
> v6:
> - No change.
>
> drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> 1 file changed, 1 insertion(+)
I have not seen any comment on any layerscape driver patches
coming from the maintainers as listed in the MAINTAINERS
file (and CCed in this series).
I request maintainers ACK on these patches and I expect them
to start reviewing your code if they want to be still considered
maintainers for this driver.
The changes look OK minus Shawn's remark on compatible string
that was ignored.
Thanks,
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
> index 3a5fa26..f24f79a 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata = {
> static const struct of_device_id ls_pcie_of_match[] = {
> { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> --
> 2.9.5
>
> -----Original Message-----
> From: Lorenzo Pieralisi <[email protected]>
> Sent: 2019??11??5?? 20:33
> To: Xiaowei Bao <[email protected]>
> Cc: [email protected]; [email protected]; [email protected]; Leo
> Li <[email protected]>; M.h. Lian <[email protected]>; Mingkai Hu
> <[email protected]>; Roy Zang <[email protected]>;
> [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; Z.q. Hou
> <[email protected]>
> Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
>
> On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> > Add support for the LS1028a PCIe controller.
> >
> > Signed-off-by: Xiaowei Bao <[email protected]>
> > Signed-off-by: Hou Zhiqiang <[email protected]>
> > ---
> > v2:
> > - No change.
> > v3:
> > - Reuse the ls2088 driver data structurt.
> > v4:
> > - No change.
> > v5:
> > - No change.
> > v6:
> > - No change.
> >
> > drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> I have not seen any comment on any layerscape driver patches coming from
> the maintainers as listed in the MAINTAINERS file (and CCed in this series).
>
> I request maintainers ACK on these patches and I expect them to start
> reviewing your code if they want to be still considered maintainers for this
> driver.
>
> The changes look OK minus Shawn's remark on compatible string that was
> ignored.
Hi Lorenzo,
Thanks for your comments.
In fact, the patches have reviewed in our internal mail list, after the review by Minghuan
and Mingkai, I will send these patches to opensource, they will give the ACK when these
patches seems is OK and no comments on this.
Thanks
Xiaowei
>
> Thanks,
> Lorenzo
>
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c
> > b/drivers/pci/controller/dwc/pci-layerscape.c
> > index 3a5fa26..f24f79a 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata
> > = { static const struct of_device_id ls_pcie_of_match[] = {
> > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
> > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> > --
> > 2.9.5
> >
Hi Lorenzo,
Sorry for the late reply.
Acked-by: Minghuan Lian <[email protected]>
Thanks,
Minghuan
> -----Original Message-----
> From: Xiaowei Bao <[email protected]>
> Sent: Wednesday, November 6, 2019 11:36 AM
> To: Lorenzo Pieralisi <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> Leo Li <[email protected]>; M.h. Lian <[email protected]>; Mingkai
> Hu <[email protected]>; Roy Zang <[email protected]>; linux-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; linuxppc-
> [email protected]; [email protected]; Z.q. Hou
> <[email protected]>
> Subject: RE: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
>
>
>
> > -----Original Message-----
> > From: Lorenzo Pieralisi <[email protected]>
> > Sent: 2019??11??5?? 20:33
> > To: Xiaowei Bao <[email protected]>
> > Cc: [email protected]; [email protected]; [email protected];
> Leo
> > Li <[email protected]>; M.h. Lian <[email protected]>; Mingkai
> Hu
> > <[email protected]>; Roy Zang <[email protected]>;
> > [email protected]; [email protected];
> > [email protected]; [email protected];
> > [email protected]; [email protected]; Z.q. Hou
> > <[email protected]>
> > Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
> >
> > On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> > > Add support for the LS1028a PCIe controller.
> > >
> > > Signed-off-by: Xiaowei Bao <[email protected]>
> > > Signed-off-by: Hou Zhiqiang <[email protected]>
> > > ---
> > > v2:
> > > - No change.
> > > v3:
> > > - Reuse the ls2088 driver data structurt.
> > > v4:
> > > - No change.
> > > v5:
> > > - No change.
> > > v6:
> > > - No change.
> > >
> > > drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > I have not seen any comment on any layerscape driver patches coming
> > from the maintainers as listed in the MAINTAINERS file (and CCed in this
> series).
> >
> > I request maintainers ACK on these patches and I expect them to start
> > reviewing your code if they want to be still considered maintainers
> > for this driver.
> >
> > The changes look OK minus Shawn's remark on compatible string that was
> > ignored.
>
> Hi Lorenzo,
>
> Thanks for your comments.
>
> In fact, the patches have reviewed in our internal mail list, after the review by
> Minghuan and Mingkai, I will send these patches to opensource, they will
> give the ACK when these patches seems is OK and no comments on this.
>
> Thanks
> Xiaowei
>
> >
> > Thanks,
> > Lorenzo
> >
> > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c
> > > b/drivers/pci/controller/dwc/pci-layerscape.c
> > > index 3a5fa26..f24f79a 100644
> > > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata
> > > ls2088_drvdata = { static const struct of_device_id ls_pcie_of_match[] = {
> > > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> > > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> > > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
> > > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> > > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> > > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> > > --
> > > 2.9.5
> > >
On Wed, Nov 06, 2019 at 03:46:17AM +0000, M.h. Lian wrote:
> Hi Lorenzo,
>
> Sorry for the late reply.
>
> Acked-by: Minghuan Lian <[email protected]>
https://en.wikipedia.org/wiki/Posting_style#Top-posting
Never top-post on kernel mailing lists.
Thanks,
Lorenzo
> Thanks,
> Minghuan
>
> > -----Original Message-----
> > From: Xiaowei Bao <[email protected]>
> > Sent: Wednesday, November 6, 2019 11:36 AM
> > To: Lorenzo Pieralisi <[email protected]>
> > Cc: [email protected]; [email protected]; [email protected];
> > Leo Li <[email protected]>; M.h. Lian <[email protected]>; Mingkai
> > Hu <[email protected]>; Roy Zang <[email protected]>; linux-
> > [email protected]; [email protected]; linux-
> > [email protected]; [email protected]; linuxppc-
> > [email protected]; [email protected]; Z.q. Hou
> > <[email protected]>
> > Subject: RE: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
> >
> >
> >
> > > -----Original Message-----
> > > From: Lorenzo Pieralisi <[email protected]>
> > > Sent: 2019年11月5日 20:33
> > > To: Xiaowei Bao <[email protected]>
> > > Cc: [email protected]; [email protected]; [email protected];
> > Leo
> > > Li <[email protected]>; M.h. Lian <[email protected]>; Mingkai
> > Hu
> > > <[email protected]>; Roy Zang <[email protected]>;
> > > [email protected]; [email protected];
> > > [email protected]; [email protected];
> > > [email protected]; [email protected]; Z.q. Hou
> > > <[email protected]>
> > > Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
> > >
> > > On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> > > > Add support for the LS1028a PCIe controller.
> > > >
> > > > Signed-off-by: Xiaowei Bao <[email protected]>
> > > > Signed-off-by: Hou Zhiqiang <[email protected]>
> > > > ---
> > > > v2:
> > > > - No change.
> > > > v3:
> > > > - Reuse the ls2088 driver data structurt.
> > > > v4:
> > > > - No change.
> > > > v5:
> > > > - No change.
> > > > v6:
> > > > - No change.
> > > >
> > > > drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > >
> > > I have not seen any comment on any layerscape driver patches coming
> > > from the maintainers as listed in the MAINTAINERS file (and CCed in this
> > series).
> > >
> > > I request maintainers ACK on these patches and I expect them to start
> > > reviewing your code if they want to be still considered maintainers
> > > for this driver.
> > >
> > > The changes look OK minus Shawn's remark on compatible string that was
> > > ignored.
> >
> > Hi Lorenzo,
> >
> > Thanks for your comments.
> >
> > In fact, the patches have reviewed in our internal mail list, after the review by
> > Minghuan and Mingkai, I will send these patches to opensource, they will
> > give the ACK when these patches seems is OK and no comments on this.
> >
> > Thanks
> > Xiaowei
> >
> > >
> > > Thanks,
> > > Lorenzo
> > >
> > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c
> > > > b/drivers/pci/controller/dwc/pci-layerscape.c
> > > > index 3a5fa26..f24f79a 100644
> > > > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > > > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > > > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata
> > > > ls2088_drvdata = { static const struct of_device_id ls_pcie_of_match[] = {
> > > > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> > > > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> > > > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
> > > > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> > > > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> > > > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> > > > --
> > > > 2.9.5
> > > >