2020-02-26 15:48:26

by Gerd Hoffmann

Subject: [PATCH v5 2/3] drm/virtio: fix mmap page attributes

virtio-gpu uses cached mappings, set
drm_gem_shmem_object.map_cached accordingly.

Cc: [email protected]
Fixes: c66df701e783 ("drm/virtio: switch from ttm to gem shmem helpers")
Reported-by: Gurchetan Singh <[email protected]>
Reported-by: Guillaume Gardet <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
---
drivers/gpu/drm/virtio/virtgpu_object.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c
index 3d2a6d489bfc..59319435218f 100644
--- a/drivers/gpu/drm/virtio/virtgpu_object.c
+++ b/drivers/gpu/drm/virtio/virtgpu_object.c
@@ -119,6 +119,7 @@ struct drm_gem_object *virtio_gpu_create_object(struct drm_device *dev,
return NULL;

bo->base.base.funcs = &virtio_gpu_gem_funcs;
+ bo->base.map_cached = true;
return &bo->base.base;
}

--
2.18.2

2020-02-26 16:54:38

by Guillaume Gardet

Subject: RE: [PATCH v5 2/3] drm/virtio: fix mmap page attributes

> -----Original Message-----
> From: Gerd Hoffmann <[email protected]>
> Sent: 26 February 2020 16:48
> To: [email protected]
> Cc: [email protected]; [email protected]; [email protected];
> Guillaume Gardet <[email protected]>; Gerd Hoffmann
> <[email protected]>; [email protected]; David Airlie <[email protected]>;
> Daniel Vetter <[email protected]>; open list:VIRTIO GPU DRIVER
> <[email protected]>; open list <linux-
> [email protected]>
> Subject: [PATCH v5 2/3] drm/virtio: fix mmap page attributes
>
> virtio-gpu uses cached mappings, set
> drm_gem_shmem_object.map_cached accordingly.
>
> Cc: [email protected]
> Fixes: c66df701e783 ("drm/virtio: switch from ttm to gem shmem helpers")
> Reported-by: Gurchetan Singh <[email protected]>
> Reported-by: Guillaume Gardet <[email protected]>
> Signed-off-by: Gerd Hoffmann <[email protected]>

Tested-by: Guillaume Gardet <[email protected]>

> ---
> drivers/gpu/drm/virtio/virtgpu_object.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c
> b/drivers/gpu/drm/virtio/virtgpu_object.c
> index 3d2a6d489bfc..59319435218f 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_object.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_object.c
> @@ -119,6 +119,7 @@ struct drm_gem_object *virtio_gpu_create_object(struct
> drm_device *dev,
> return NULL;
>
> bo->base.base.funcs = &virtio_gpu_gem_funcs;
> +bo->base.map_cached = true;
> return &bo->base.base;
> }
>
> --
> 2.18.2

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.