2022-10-24 04:41:29

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the imx-mxs tree

Hi all,

In commit

c9545754e9a7 ("arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci")

Fixes tag

Fixes: 1d8df9c74bff ("arm64: dts: freescale: add initial support for verdin imx8m plus")

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-10-24 07:17:26

by Francesco Dolcini

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree

On Mon, Oct 24, 2022 at 03:37:20PM +1100, Stephen Rothwell wrote:
> In commit
>
> c9545754e9a7 ("arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci")
>
> Fixes tag
>
> Fixes: 1d8df9c74bff ("arm64: dts: freescale: add initial support for verdin imx8m plus")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")
correct, sorry for the mistake :/

Shawn: I assume you can fix it, let me know otherwise.

Hopefully since commit bd17e036b495 ("checkpatch: warn for non-standard fixes tag style")
was merged these kind of mistakes should be less and less frequent.

Francesco

2022-10-24 07:21:00

by Marcel Ziswiler

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree

Hi Stephen

On Mon, 2022-10-24 at 15:37 +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   c9545754e9a7 ("arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci")
>
> Fixes tag
>
>   Fixes: 1d8df9c74bff ("arm64: dts: freescale: add initial support for verdin imx8m plus")

Oh shoot, I guess Max referenced the commit from our downstream branch and while I checked the commit to exist
on my end I missed it being a downstream one:

⬢[zim@toolbox linux-toradex-imx.git]$ git branch --contains 1d8df9c74bff5d36d755324be1e695abf9cdeca8
toradex_5.15-2.0.x-imx

> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")

Yes, Indeed, that must be the correct one:

⬢[zim@toolbox linux-next.git]$ git branch --contains a39ed23bdf6ec7eb0f093b6ef0391e1f3d152f71
v5.19
v6.0

Sorry about that!

@Shawn: Can you fix this up or do I need to re-send anything?

Thanks!

Cheers

Marcel

2022-10-29 08:41:00

by Shawn Guo

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the imx-mxs tree

On Mon, Oct 24, 2022 at 07:07:26AM +0000, Marcel Ziswiler wrote:
> Hi Stephen
>
> On Mon, 2022-10-24 at 15:37 +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   c9545754e9a7 ("arm64: dts: verdin-imx8mp: fix ctrl_sleep_moci")
> >
> > Fixes tag
> >
> >   Fixes: 1d8df9c74bff ("arm64: dts: freescale: add initial support for verdin imx8m plus")
>
> Oh shoot, I guess Max referenced the commit from our downstream branch and while I checked the commit to exist
> on my end I missed it being a downstream one:
>
> ⬢[zim@toolbox linux-toradex-imx.git]$ git branch --contains 1d8df9c74bff5d36d755324be1e695abf9cdeca8
> toradex_5.15-2.0.x-imx
>
> > has these problem(s):
> >
> >   - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")
>
> Yes, Indeed, that must be the correct one:
>
> ⬢[zim@toolbox linux-next.git]$ git branch --contains a39ed23bdf6ec7eb0f093b6ef0391e1f3d152f71
> v5.19
> v6.0
>
> Sorry about that!
>
> @Shawn: Can you fix this up or do I need to re-send anything?

Fixed.

Shawn