2022-11-03 21:25:54

by Wolfram Sang

[permalink] [raw]
Subject: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly

Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer")
Signed-off-by: Wolfram Sang <[email protected]>
---
arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
index bb4dd08781ca..c10740aee9f6 100644
--- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
@@ -271,11 +271,11 @@ user@1200000 {
};
};

-&scif_clk {
- clock-frequency = <24000000>;
-};
-
&rwdt {
timeout-sec = <60>;
status = "okay";
};
+
+&scif_clk {
+ clock-frequency = <24000000>;
+};
--
2.35.1



2022-11-03 22:14:58

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly

On 03/11/2022 16:55, Wolfram Sang wrote:

You need to describe the bug and its impact to justify Fixes tag (thus
AUTOSEL backporting).

> Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer")

But I doubt that there is a bug here. Style (like order of things) is
not a bug.


> Signed-off-by: Wolfram Sang <[email protected]>
> ---
> arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> index bb4dd08781ca..c10740aee9f6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi
> @@ -271,11 +271,11 @@ user@1200000 {
> };
> };
>
> -&scif_clk {
> - clock-frequency = <24000000>;
> -};
> -
> &rwdt {
> timeout-sec = <60>;
> status = "okay";
> };
> +
> +&scif_clk {
> + clock-frequency = <24000000>;
> +};

Best regards,
Krzysztof


2022-11-04 09:32:33

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly

On Thu, Nov 3, 2022 at 9:55 PM Wolfram Sang
<[email protected]> wrote:
> Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer")
> Signed-off-by: Wolfram Sang <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v6.2.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2022-11-04 11:29:28

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly


> But I doubt that there is a bug here. Style (like order of things) is
> not a bug.

Okay, I'll be more strict next time. Geert, could you kindly drop the
Fixes tag or shall I resend?


Attachments:
(No filename) (194.00 B)
signature.asc (849.00 B)
Download all attachments

2022-11-04 12:40:42

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 3/4] arm64: dts: renesas: white-hawk-cpu: sort RWDT entry correctly

Hi Wolfram,

On Fri, Nov 4, 2022 at 12:15 PM Wolfram Sang
<[email protected]> wrote:
> > But I doubt that there is a bug here. Style (like order of things) is
> > not a bug.
>
> Okay, I'll be more strict next time. Geert, could you kindly drop the
> Fixes tag or shall I resend?

Consider it done, no need to resend.
BTW, I guess the stable machinery will pick it up anyway...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds