2022-11-22 13:23:12

by John Keeping

[permalink] [raw]
Subject: [PATCH 0/3] usb: gadget: f_hid: fix f_hidg lifetime vs cdev

This series arises from the recent thread [1] on lifetime issues.

The main point is the first patch, with the second being an unrelated
fix for an issue spotted while working on this. Both of these have
Fixes: tags for backporting to stable.

The final patch tidies up some error handling to hopefully avoid patch 2
issues in the future.

[1] https://lore.kernel.org/r/[email protected]

John Keeping (3):
usb: gadget: f_hid: fix f_hidg lifetime vs cdev
usb: gadget: f_hid: fix refcount leak on error path
usb: gadget: f_hid: tidy error handling in hidg_alloc

drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++-------------
1 file changed, 33 insertions(+), 27 deletions(-)

--
2.38.1


2022-11-22 19:00:45

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH 0/3] usb: gadget: f_hid: fix f_hidg lifetime vs cdev

On Tue, 22 Nov 2022, John Keeping wrote:

> This series arises from the recent thread [1] on lifetime issues.
>
> The main point is the first patch, with the second being an unrelated
> fix for an issue spotted while working on this. Both of these have
> Fixes: tags for backporting to stable.
>
> The final patch tidies up some error handling to hopefully avoid patch 2
> issues in the future.
>
> [1] https://lore.kernel.org/r/[email protected]
>
> John Keeping (3):
> usb: gadget: f_hid: fix f_hidg lifetime vs cdev
> usb: gadget: f_hid: fix refcount leak on error path
> usb: gadget: f_hid: tidy error handling in hidg_alloc
>
> drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++-------------
> 1 file changed, 33 insertions(+), 27 deletions(-)

For the set:

Reviewed-by: Lee Jones <[email protected]>
Tested-by: Lee Jones <[email protected]>

--
Lee Jones [李琼斯]

2022-11-28 14:41:36

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH 0/3] usb: gadget: f_hid: fix f_hidg lifetime vs cdev

On Tue, 22 Nov 2022, Lee Jones wrote:

> On Tue, 22 Nov 2022, John Keeping wrote:
>
> > This series arises from the recent thread [1] on lifetime issues.
> >
> > The main point is the first patch, with the second being an unrelated
> > fix for an issue spotted while working on this. Both of these have
> > Fixes: tags for backporting to stable.
> >
> > The final patch tidies up some error handling to hopefully avoid patch 2
> > issues in the future.
> >
> > [1] https://lore.kernel.org/r/[email protected]
> >
> > John Keeping (3):
> > usb: gadget: f_hid: fix f_hidg lifetime vs cdev
> > usb: gadget: f_hid: fix refcount leak on error path
> > usb: gadget: f_hid: tidy error handling in hidg_alloc
> >
> > drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++-------------
> > 1 file changed, 33 insertions(+), 27 deletions(-)
>
> For the set:
>
> Reviewed-by: Lee Jones <[email protected]>
> Tested-by: Lee Jones <[email protected]>

Greg, is this still on your radar?

--
Lee Jones [李琼斯]

2022-11-28 18:38:12

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 0/3] usb: gadget: f_hid: fix f_hidg lifetime vs cdev

On Mon, Nov 28, 2022 at 02:04:13PM +0000, Lee Jones wrote:
> On Tue, 22 Nov 2022, Lee Jones wrote:
>
> > On Tue, 22 Nov 2022, John Keeping wrote:
> >
> > > This series arises from the recent thread [1] on lifetime issues.
> > >
> > > The main point is the first patch, with the second being an unrelated
> > > fix for an issue spotted while working on this. Both of these have
> > > Fixes: tags for backporting to stable.
> > >
> > > The final patch tidies up some error handling to hopefully avoid patch 2
> > > issues in the future.
> > >
> > > [1] https://lore.kernel.org/r/[email protected]
> > >
> > > John Keeping (3):
> > > usb: gadget: f_hid: fix f_hidg lifetime vs cdev
> > > usb: gadget: f_hid: fix refcount leak on error path
> > > usb: gadget: f_hid: tidy error handling in hidg_alloc
> > >
> > > drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++-------------
> > > 1 file changed, 33 insertions(+), 27 deletions(-)
> >
> > For the set:
> >
> > Reviewed-by: Lee Jones <[email protected]>
> > Tested-by: Lee Jones <[email protected]>
>
> Greg, is this still on your radar?

Yes, let me catch up on pending patches...

2022-11-29 09:09:48

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH 0/3] usb: gadget: f_hid: fix f_hidg lifetime vs cdev

On Mon, 28 Nov 2022, Greg Kroah-Hartman wrote:

> On Mon, Nov 28, 2022 at 02:04:13PM +0000, Lee Jones wrote:
> > On Tue, 22 Nov 2022, Lee Jones wrote:
> >
> > > On Tue, 22 Nov 2022, John Keeping wrote:
> > >
> > > > This series arises from the recent thread [1] on lifetime issues.
> > > >
> > > > The main point is the first patch, with the second being an unrelated
> > > > fix for an issue spotted while working on this. Both of these have
> > > > Fixes: tags for backporting to stable.
> > > >
> > > > The final patch tidies up some error handling to hopefully avoid patch 2
> > > > issues in the future.
> > > >
> > > > [1] https://lore.kernel.org/r/[email protected]
> > > >
> > > > John Keeping (3):
> > > > usb: gadget: f_hid: fix f_hidg lifetime vs cdev
> > > > usb: gadget: f_hid: fix refcount leak on error path
> > > > usb: gadget: f_hid: tidy error handling in hidg_alloc
> > > >
> > > > drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++-------------
> > > > 1 file changed, 33 insertions(+), 27 deletions(-)
> > >
> > > For the set:
> > >
> > > Reviewed-by: Lee Jones <[email protected]>
> > > Tested-by: Lee Jones <[email protected]>
> >
> > Greg, is this still on your radar?
>
> Yes, let me catch up on pending patches...

Perfect, thank you.

--
Lee Jones [李琼斯]