2022-11-12 15:37:40

by Aidan MacDonald

Subject: [PATCH 11/18] mfd: rohm-bd718x7: Drop useless mask_invert flag on irqchip

Setting mask_invert to false is pointless because that's the
default. The flag is also deprecated, so drop it.

Signed-off-by: Aidan MacDonald <[email protected]>
---
drivers/mfd/rohm-bd718x7.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
index bfd81f78beae..ad6c0971a997 100644
--- a/drivers/mfd/rohm-bd718x7.c
+++ b/drivers/mfd/rohm-bd718x7.c
@@ -70,7 +70,6 @@ static struct regmap_irq_chip bd718xx_irq_chip = {
.mask_base = BD718XX_REG_MIRQ,
.ack_base = BD718XX_REG_IRQ,
.init_ack_masked = true,
- .mask_invert = false,
};

static const struct regmap_range pmic_status_range = {
--
2.38.1

2022-11-14 07:09:09

by Matti Vaittinen

Subject: Re: [PATCH 11/18] mfd: rohm-bd718x7: Drop useless mask_invert flag on irqchip

On 11/12/22 17:18, Aidan MacDonald wrote:
> Setting mask_invert to false is pointless because that's the
> default. The flag is also deprecated, so drop it.
>
> Signed-off-by: Aidan MacDonald <[email protected]>
Reviewed-by: Matti Vaittinen <[email protected]>

> ---
> drivers/mfd/rohm-bd718x7.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
> index bfd81f78beae..ad6c0971a997 100644
> --- a/drivers/mfd/rohm-bd718x7.c
> +++ b/drivers/mfd/rohm-bd718x7.c
> @@ -70,7 +70,6 @@ static struct regmap_irq_chip bd718xx_irq_chip = {
> .mask_base = BD718XX_REG_MIRQ,
> .ack_base = BD718XX_REG_IRQ,
> .init_ack_masked = true,
> - .mask_invert = false,
> };
>
> static const struct regmap_range pmic_status_range = {

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

2022-11-16 18:48:52

by Lee Jones

Subject: Re: [PATCH 11/18] mfd: rohm-bd718x7: Drop useless mask_invert flag on irqchip

On Sat, 12 Nov 2022, Aidan MacDonald wrote:

> Setting mask_invert to false is pointless because that's the
> default. The flag is also deprecated, so drop it.
>
> Signed-off-by: Aidan MacDonald <[email protected]>
> ---
> drivers/mfd/rohm-bd718x7.c | 1 -
> 1 file changed, 1 deletion(-)

Applied, thanks.

--
Lee Jones [李琼斯]