2022-11-16 08:28:18

by Matti Vaittinen

[permalink] [raw]
Subject: [PATCH RESEND] mfd: bd957x: Fix Kconfig dependency

The bd957x driver uses regmap-IRQ but does not SELECT ot depend on it.
This can cause build failure.

SELECT the regmap-IRQ for BD957X from Kconfig.

Fixes: 0e9692607f94 ("mfd: bd9576: Add IRQ support")
Signed-off-by: Matti Vaittinen <[email protected]>
---
Oh, found this forgotten treasure while cleaning old branches from my
local git. It seems to me this is still valid but has fallen through the
cracks.

drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 8b93856de432..9940e2724c05 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -2027,6 +2027,7 @@ config MFD_ROHM_BD957XMUF
depends on I2C=y
depends on OF
select REGMAP_I2C
+ select REGMAP_IRQ
select MFD_CORE
help
Select this option to get support for the ROHM BD9576MUF and

base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa
--
2.38.1


--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]


Attachments:
(No filename) (1.25 kB)
signature.asc (499.00 B)
Download all attachments

2022-11-16 18:38:04

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH RESEND] mfd: bd957x: Fix Kconfig dependency

On Wed, 16 Nov 2022, Matti Vaittinen wrote:

> The bd957x driver uses regmap-IRQ but does not SELECT ot depend on it.
> This can cause build failure.
>
> SELECT the regmap-IRQ for BD957X from Kconfig.
>
> Fixes: 0e9692607f94 ("mfd: bd9576: Add IRQ support")
> Signed-off-by: Matti Vaittinen <[email protected]>
> ---
> Oh, found this forgotten treasure while cleaning old branches from my
> local git. It seems to me this is still valid but has fallen through the
> cracks.
>
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Applied with some commit-log clean-up.

--
Lee Jones [李琼斯]