2021-02-05 13:17:40

by Bhaskar Chowdhury

[permalink] [raw]
Subject: Re: [PATCH] fs: notify: inotify: Replace a common bad word with better common word

On 14:45 Fri 05 Feb 2021, Amir Goldstein wrote:
>On Fri, Feb 5, 2021 at 2:20 PM Bhaskar Chowdhury <[email protected]> wrote:
>>
>>
>>
>> s/fucked/messed/
>>
>> Signed-off-by: Bhaskar Chowdhury <[email protected]>
>> ---
>> fs/notify/inotify/inotify_user.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
>> index 59c177011a0f..0a9d1a81edf0 100644
>> --- a/fs/notify/inotify/inotify_user.c
>> +++ b/fs/notify/inotify/inotify_user.c
>> @@ -455,7 +455,7 @@ static void inotify_remove_from_idr(struct fsnotify_group *group,
>> /*
>> * We found an mark in the idr at the right wd, but it's
>> * not the mark we were told to remove. eparis seriously
>> - * fucked up somewhere.
>> + * messed up somewhere.
>> */
>> if (unlikely(found_i_mark != i_mark)) {
>> WARN_ONCE(1, "%s: i_mark=%p i_mark->wd=%d i_mark->group=%p "
>> --
>> 2.30.0
>>
>
>Same comment as the previous attempt:
>
>https://lore.kernel.org/linux-fsdevel/[email protected]/
>
>Please remove the part of the comment that adds no valuable information
>and fix grammar mistakes.
>
I am not sure Amir ..could you please pinpoint that.


>Thanks,
>Amir.


Attachments:
(No filename) (1.32 kB)
signature.asc (499.00 B)
Download all attachments

2021-02-05 23:41:49

by Amir Goldstein

[permalink] [raw]
Subject: Re: [PATCH] fs: notify: inotify: Replace a common bad word with better common word

On Fri, Feb 5, 2021 at 3:12 PM Bhaskar Chowdhury <[email protected]> wrote:
>
> On 14:45 Fri 05 Feb 2021, Amir Goldstein wrote:
> >On Fri, Feb 5, 2021 at 2:20 PM Bhaskar Chowdhury <[email protected]> wrote:
> >>
> >>
> >>
> >> s/fucked/messed/
> >>
> >> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> >> ---
> >> fs/notify/inotify/inotify_user.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
> >> index 59c177011a0f..0a9d1a81edf0 100644
> >> --- a/fs/notify/inotify/inotify_user.c
> >> +++ b/fs/notify/inotify/inotify_user.c
> >> @@ -455,7 +455,7 @@ static void inotify_remove_from_idr(struct fsnotify_group *group,
> >> /*
> >> * We found an mark in the idr at the right wd, but it's
> >> * not the mark we were told to remove. eparis seriously
> >> - * fucked up somewhere.
> >> + * messed up somewhere.
> >> */
> >> if (unlikely(found_i_mark != i_mark)) {
> >> WARN_ONCE(1, "%s: i_mark=%p i_mark->wd=%d i_mark->group=%p "
> >> --
> >> 2.30.0
> >>
> >
> >Same comment as the previous attempt:
> >
> >https://lore.kernel.org/linux-fsdevel/[email protected]/
> >
> >Please remove the part of the comment that adds no valuable information
> >and fix grammar mistakes.
> >
> I am not sure Amir ..could you please pinpoint that.
>

/*
* We found a mark in the idr at the right wd, but it's
* not the mark we were told to remove.
*/

Thanks,
Amir.