2021-02-01 07:44:17

by Yang Li

Subject: [PATCH] perf metricgroup: remove unneeded semicolon

Eliminate the following coccicheck warning:
./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
tools/perf/util/metricgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index e6d3452..26c990e 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups,
metric_refs[i].metric_expr = ref->metric_expr;
i++;
}
- };
+ }

expr->metric_refs = metric_refs;
expr->metric_expr = m->metric_expr;
--
1.8.3.1

2021-02-16 07:38:16

by Namhyung Kim

Subject: Re: [PATCH] perf metricgroup: remove unneeded semicolon

Hello,

On Mon, Feb 1, 2021 at 4:41 PM Yang Li <[email protected]> wrote:
>
> Eliminate the following coccicheck warning:
> ./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung

> ---
> tools/perf/util/metricgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index e6d3452..26c990e 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups,
> metric_refs[i].metric_expr = ref->metric_expr;
> i++;
> }
> - };
> + }
>
> expr->metric_refs = metric_refs;
> expr->metric_expr = m->metric_expr;
> --
> 1.8.3.1
>

2021-02-17 20:59:01

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf metricgroup: remove unneeded semicolon

Em Tue, Feb 16, 2021 at 04:34:25PM +0900, Namhyung Kim escreveu:
> Hello,
>
> On Mon, Feb 1, 2021 at 4:41 PM Yang Li <[email protected]> wrote:
> >
> > Eliminate the following coccicheck warning:
> > ./tools/perf/util/metricgroup.c:382:3-4: Unneeded semicolon
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
>
> Acked-by: Namhyung Kim <[email protected]>

Thanks, applied.

- Arnaldo


> Thanks,
> Namhyung
>
> > ---
> > tools/perf/util/metricgroup.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> > index e6d3452..26c990e 100644
> > --- a/tools/perf/util/metricgroup.c
> > +++ b/tools/perf/util/metricgroup.c
> > @@ -379,7 +379,7 @@ static int metricgroup__setup_events(struct list_head *groups,
> > metric_refs[i].metric_expr = ref->metric_expr;
> > i++;
> > }
> > - };
> > + }
> >
> > expr->metric_refs = metric_refs;
> > expr->metric_expr = m->metric_expr;
> > --
> > 1.8.3.1
> >

--

- Arnaldo