2021-02-15 12:50:53

by Martin Liška

Subject: [PATCH] perf annotate: do not jump after 'k' is pressed

Do not jump when 'k' is pressed, the cursor show stay where it is.
Right now, it jumps to the currently selected hot instruction.

Signed-off-by: Martin Liška <[email protected]>
---
tools/perf/ui/browsers/annotate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index bd77825fd5a1..35b82caf8090 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -759,7 +759,7 @@ static int annotate_browser__run(struct annotate_browser *browser,
continue;
case 'k':
notes->options->show_linenr = !notes->options->show_linenr;
- break;
+ continue;
case 'H':
nd = browser->curr_hot;
break;
--
2.30.0

2021-02-17 21:00:30

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf annotate: do not jump after 'k' is pressed

Em Mon, Feb 15, 2021 at 01:45:25PM +0100, Martin Liška escreveu:
> Do not jump when 'k' is pressed, the cursor show stay where it is.
> Right now, it jumps to the currently selected hot instruction.

Thanks, applied.

- Arnaldo


> Signed-off-by: Martin Liška <[email protected]>
> ---
> tools/perf/ui/browsers/annotate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
> index bd77825fd5a1..35b82caf8090 100644
> --- a/tools/perf/ui/browsers/annotate.c
> +++ b/tools/perf/ui/browsers/annotate.c
> @@ -759,7 +759,7 @@ static int annotate_browser__run(struct annotate_browser *browser,
> continue;
> case 'k':
> notes->options->show_linenr = !notes->options->show_linenr;
> - break;
> + continue;
> case 'H':
> nd = browser->curr_hot;
> break;
> --
> 2.30.0
>

--

- Arnaldo