2021-03-02 19:51:38

by Rajendra Nayak

Subject: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets

The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
due to an issue in the scripts generating the data.

Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")

Reported-by: Veerabhadrarao Badiganti <[email protected]>
Signed-off-by: Rajendra Nayak <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-sc7280.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
index 8daccd5..49c4347 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
@@ -1439,14 +1439,14 @@ static const struct msm_pingroup sc7280_groups[] = {
[172] = PINGROUP(172, qdss, _, _, _, _, _, _, _, _),
[173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
[174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
- [175] = UFS_RESET(ufs_reset, 0x1be000),
- [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x1b3000, 15, 0),
- [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0x1b3000, 13, 6),
- [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x1b3000, 11, 3),
- [179] = SDC_QDSD_PINGROUP(sdc1_data, 0x1b3000, 9, 0),
- [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1b4000, 14, 6),
- [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1b4000, 11, 3),
- [182] = SDC_QDSD_PINGROUP(sdc2_data, 0x1b4000, 9, 0),
+ [175] = UFS_RESET(ufs_reset, 0xbe000),
+ [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
+ [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
+ [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
+ [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
+ [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0xb4000, 14, 6),
+ [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xb4000, 11, 3),
+ [182] = SDC_QDSD_PINGROUP(sdc2_data, 0xb4000, 9, 0),
};

static const struct msm_pinctrl_soc_data sc7280_pinctrl = {
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-03-04 05:47:51

by Rajendra Nayak

Subject: [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations

Fix SDC1_RCLK configurations which are in a different register so fix the
offset from 0xb3000 to 0xb3004.

Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")

Reported-by: Veerabhadrarao Badiganti <[email protected]>
Signed-off-by: Rajendra Nayak <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-sc7280.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
index 49c4347..9d41abf 100644
--- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
+++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
@@ -1440,7 +1440,7 @@ static const struct msm_pingroup sc7280_groups[] = {
[173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
[174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
[175] = UFS_RESET(ufs_reset, 0xbe000),
- [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
+ [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3004, 0, 6),
[177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
[178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
[179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-03-09 20:07:57

by Bjorn Andersson

Subject: Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets

On Mon 01 Mar 23:21 CST 2021, Rajendra Nayak wrote:

> The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
> due to an issue in the scripts generating the data.
>
> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>
> Reported-by: Veerabhadrarao Badiganti <[email protected]>
> Signed-off-by: Rajendra Nayak <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> drivers/pinctrl/qcom/pinctrl-sc7280.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> index 8daccd5..49c4347 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> @@ -1439,14 +1439,14 @@ static const struct msm_pingroup sc7280_groups[] = {
> [172] = PINGROUP(172, qdss, _, _, _, _, _, _, _, _),
> [173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
> [174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
> - [175] = UFS_RESET(ufs_reset, 0x1be000),
> - [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x1b3000, 15, 0),
> - [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0x1b3000, 13, 6),
> - [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x1b3000, 11, 3),
> - [179] = SDC_QDSD_PINGROUP(sdc1_data, 0x1b3000, 9, 0),
> - [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1b4000, 14, 6),
> - [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1b4000, 11, 3),
> - [182] = SDC_QDSD_PINGROUP(sdc2_data, 0x1b4000, 9, 0),
> + [175] = UFS_RESET(ufs_reset, 0xbe000),
> + [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
> + [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
> + [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
> + [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
> + [180] = SDC_QDSD_PINGROUP(sdc2_clk, 0xb4000, 14, 6),
> + [181] = SDC_QDSD_PINGROUP(sdc2_cmd, 0xb4000, 11, 3),
> + [182] = SDC_QDSD_PINGROUP(sdc2_data, 0xb4000, 9, 0),
> };
>
> static const struct msm_pinctrl_soc_data sc7280_pinctrl = {
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>

2021-03-09 20:13:26

by Bjorn Andersson

Subject: Re: [PATCH 2/2] pinctrl: qcom: sc7280: Fix SDC1_RCLK configurations

On Mon 01 Mar 23:21 CST 2021, Rajendra Nayak wrote:

> Fix SDC1_RCLK configurations which are in a different register so fix the
> offset from 0xb3000 to 0xb3004.
>
> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>

Acked-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> Reported-by: Veerabhadrarao Badiganti <[email protected]>
> Signed-off-by: Rajendra Nayak <[email protected]>
> ---
> drivers/pinctrl/qcom/pinctrl-sc7280.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> index 49c4347..9d41abf 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280.c
> @@ -1440,7 +1440,7 @@ static const struct msm_pingroup sc7280_groups[] = {
> [173] = PINGROUP(173, qdss, _, _, _, _, _, _, _, _),
> [174] = PINGROUP(174, qdss, _, _, _, _, _, _, _, _),
> [175] = UFS_RESET(ufs_reset, 0xbe000),
> - [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3000, 15, 0),
> + [176] = SDC_QDSD_PINGROUP(sdc1_rclk, 0xb3004, 0, 6),
> [177] = SDC_QDSD_PINGROUP(sdc1_clk, 0xb3000, 13, 6),
> [178] = SDC_QDSD_PINGROUP(sdc1_cmd, 0xb3000, 11, 3),
> [179] = SDC_QDSD_PINGROUP(sdc1_data, 0xb3000, 9, 0),
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>

2021-03-10 23:56:03

by Linus Walleij

Subject: Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets

On Tue, Mar 2, 2021 at 6:22 AM Rajendra Nayak <[email protected]> wrote:

> The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
> due to an issue in the scripts generating the data.
>
> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>
> Reported-by: Veerabhadrarao Badiganti <[email protected]>
> Signed-off-by: Rajendra Nayak <[email protected]>

Both patches applied for fixes!

Yours,
Linus Walleij

2021-03-11 10:43:38

by Andy Shevchenko

Subject: Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets

On Tue, Mar 2, 2021 at 9:32 PM Rajendra Nayak <[email protected]> wrote:
>
> The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
> due to an issue in the scripts generating the data.

> Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
>
> Reported-by: Veerabhadrarao Badiganti <[email protected]>
> Signed-off-by: Rajendra Nayak <[email protected]>

Should be no blank lines in the tag block.


--
With Best Regards,
Andy Shevchenko

2021-03-11 14:42:45

by Linus Walleij

Subject: Re: [PATCH 1/2] pinctrl: qcom: sc7280: Fix SDC_QDSD_PINGROUP and UFS_RESET offsets

On Thu, Mar 11, 2021 at 11:41 AM Andy Shevchenko
<[email protected]> wrote:
> On Tue, Mar 2, 2021 at 9:32 PM Rajendra Nayak <[email protected]> wrote:
> >
> > The offsets for SDC_QDSD_PINGROUP and UFS_RESET were off by 0x100000
> > due to an issue in the scripts generating the data.
>
> > Fixes: ecb454594c43: ("pinctrl: qcom: Add sc7280 pinctrl driver")
> >
> > Reported-by: Veerabhadrarao Badiganti <[email protected]>
> > Signed-off-by: Rajendra Nayak <[email protected]>
>
> Should be no blank lines in the tag block.

Yeah I fixed it up when applying.

Just one of these maintainer perks I offer free of charge ;)

Yours,
Linus Walleij