2021-05-19 18:46:37

by Rob Herring

Subject: [PATCH 2/6] dt-bindings: rtc: nxp,pcf8563: Convert to DT schema

Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.

Add 'interrupts' as this device has an interrupt which was not
documented, but in use.

Cc: Alexandre Belloni <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/rtc/nxp,pcf8563.yaml | 50 +++++++++++++++++++
.../devicetree/bindings/rtc/pcf8563.txt | 29 -----------
2 files changed, 50 insertions(+), 29 deletions(-)
create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt

diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
new file mode 100644
index 000000000000..15e67be0ef95
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Philips PCF8563/Epson RTC8564 Real Time Clock
+
+maintainers:
+ - Alexandre Belloni <[email protected]>
+
+properties:
+ compatible:
+ enum:
+ - epson,rtc8564
+ - microcrystal,rv8564
+ - nxp,pcf8563
+ - nxp,pca8565
+
+ reg:
+ maxItems: 1
+
+ "#clock-cells":
+ const: 0
+
+ clock-output-names:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ rtc@51 {
+ compatible = "nxp,pcf8563";
+ reg = <0x51>;
+ #clock-cells = <0>;
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt
deleted file mode 100644
index 0a900f7c8977..000000000000
--- a/Documentation/devicetree/bindings/rtc/pcf8563.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-* Philips PCF8563/Epson RTC8564 Real Time Clock
-
-Philips PCF8563/Epson RTC8564 Real Time Clock
-
-Required properties:
-- compatible: Should contain "nxp,pcf8563",
- "epson,rtc8564" or
- "microcrystal,rv8564" or
- "nxp,pca8565"
-- reg: I2C address for chip.
-
-Optional property:
-- #clock-cells: Should be 0.
-- clock-output-names:
- overwrite the default clock name "pcf8563-clkout"
-
-Example:
-
-pcf8563: pcf8563@51 {
- compatible = "nxp,pcf8563";
- reg = <0x51>;
- #clock-cells = <0>;
-};
-
-device {
-...
- clocks = <&pcf8563>;
-...
-};
--
2.27.0

2021-05-19 19:00:42

by Laurent Pinchart

Subject: Re: [PATCH 2/6] dt-bindings: rtc: nxp,pcf8563: Convert to DT schema

Hi Rob,

Thank you for the patch.

On Tue, May 18, 2021 at 06:28:54PM -0500, Rob Herring wrote:
> Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.
>
> Add 'interrupts' as this device has an interrupt which was not
> documented, but in use.
>
> Cc: Alexandre Belloni <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> .../devicetree/bindings/rtc/nxp,pcf8563.yaml | 50 +++++++++++++++++++
> .../devicetree/bindings/rtc/pcf8563.txt | 29 -----------
> 2 files changed, 50 insertions(+), 29 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
> delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
> new file mode 100644
> index 000000000000..15e67be0ef95
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Philips PCF8563/Epson RTC8564 Real Time Clock
> +
> +maintainers:
> + - Alexandre Belloni <[email protected]>
> +
> +properties:
> + compatible:
> + enum:
> + - epson,rtc8564
> + - microcrystal,rv8564
> + - nxp,pcf8563
> + - nxp,pca8565
> +
> + reg:
> + maxItems: 1
> +
> + "#clock-cells":
> + const: 0
> +
> + clock-output-names:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rtc@51 {
> + compatible = "nxp,pcf8563";
> + reg = <0x51>;
> + #clock-cells = <0>;
> + };
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt
> deleted file mode 100644
> index 0a900f7c8977..000000000000
> --- a/Documentation/devicetree/bindings/rtc/pcf8563.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -* Philips PCF8563/Epson RTC8564 Real Time Clock
> -
> -Philips PCF8563/Epson RTC8564 Real Time Clock
> -
> -Required properties:
> -- compatible: Should contain "nxp,pcf8563",
> - "epson,rtc8564" or
> - "microcrystal,rv8564" or
> - "nxp,pca8565"
> -- reg: I2C address for chip.
> -
> -Optional property:
> -- #clock-cells: Should be 0.
> -- clock-output-names:
> - overwrite the default clock name "pcf8563-clkout"
> -
> -Example:
> -
> -pcf8563: pcf8563@51 {
> - compatible = "nxp,pcf8563";
> - reg = <0x51>;
> - #clock-cells = <0>;
> -};
> -
> -device {
> -...
> - clocks = <&pcf8563>;
> -...
> -};

--
Regards,

Laurent Pinchart

2021-05-25 22:41:31

by Alexandre Belloni

Subject: Re: [PATCH 2/6] dt-bindings: rtc: nxp,pcf8563: Convert to DT schema

Hello,

On 18/05/2021 18:28:54-0500, Rob Herring wrote:
> Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.
>
> Add 'interrupts' as this device has an interrupt which was not
> documented, but in use.
>

It also supports start-year from rtc.yaml.

> Cc: Alexandre Belloni <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../devicetree/bindings/rtc/nxp,pcf8563.yaml | 50 +++++++++++++++++++
> .../devicetree/bindings/rtc/pcf8563.txt | 29 -----------
> 2 files changed, 50 insertions(+), 29 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
> delete mode 100644 Documentation/devicetree/bindings/rtc/pcf8563.txt
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
> new file mode 100644
> index 000000000000..15e67be0ef95
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf8563.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Philips PCF8563/Epson RTC8564 Real Time Clock
> +
> +maintainers:
> + - Alexandre Belloni <[email protected]>
> +
> +properties:
> + compatible:
> + enum:
> + - epson,rtc8564
> + - microcrystal,rv8564
> + - nxp,pcf8563
> + - nxp,pca8565
> +
> + reg:
> + maxItems: 1
> +
> + "#clock-cells":
> + const: 0
> +
> + clock-output-names:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + rtc@51 {
> + compatible = "nxp,pcf8563";
> + reg = <0x51>;
> + #clock-cells = <0>;
> + };
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/rtc/pcf8563.txt b/Documentation/devicetree/bindings/rtc/pcf8563.txt
> deleted file mode 100644
> index 0a900f7c8977..000000000000
> --- a/Documentation/devicetree/bindings/rtc/pcf8563.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -* Philips PCF8563/Epson RTC8564 Real Time Clock
> -
> -Philips PCF8563/Epson RTC8564 Real Time Clock
> -
> -Required properties:
> -- compatible: Should contain "nxp,pcf8563",
> - "epson,rtc8564" or
> - "microcrystal,rv8564" or
> - "nxp,pca8565"
> -- reg: I2C address for chip.
> -
> -Optional property:
> -- #clock-cells: Should be 0.
> -- clock-output-names:
> - overwrite the default clock name "pcf8563-clkout"
> -
> -Example:
> -
> -pcf8563: pcf8563@51 {
> - compatible = "nxp,pcf8563";
> - reg = <0x51>;
> - #clock-cells = <0>;
> -};
> -
> -device {
> -...
> - clocks = <&pcf8563>;
> -...
> -};
> --
> 2.27.0
>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2021-05-26 22:38:29

by Rob Herring

Subject: Re: [PATCH 2/6] dt-bindings: rtc: nxp,pcf8563: Convert to DT schema

On Tue, May 25, 2021 at 4:27 PM Alexandre Belloni
<[email protected]> wrote:
>
> Hello,
>
> On 18/05/2021 18:28:54-0500, Rob Herring wrote:
> > Convert the Philips PCF8563/Epson RTC8564 binding to DT schema format.
> >
> > Add 'interrupts' as this device has an interrupt which was not
> > documented, but in use.
> >
>
> It also supports start-year from rtc.yaml.

And wakeup-source. I've added both.

Rob