2021-06-07 03:03:49

by Zou Wei

[permalink] [raw]

Subject: [PATCH -next] dmaengine: sun4i: Use list_move_tail instead of list_del/list_add_tail

---

Using list_move_tail() instead of list_del() + list_add_tail().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/dma/sun4i-dma.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
index e8b6633..93f1645 100644
--- a/drivers/dma/sun4i-dma.c
+++ b/drivers/dma/sun4i-dma.c
@@ -1042,9 +1042,8 @@ static irqreturn_t sun4i_dma_interrupt(int irq, void *dev_id)
* Move the promise into the completed list now that
* we're done with it
*/
- list_del(&vchan->processing->list);
- list_add_tail(&vchan->processing->list,
- &contract->completed_demands);
+ list_move_tail(&vchan->processing->list,
+ &contract->completed_demands);

/*
* Cyclic DMA transfers are special:
--
2.6.2

2021-06-07 08:44:45

by Maxime Ripard

[permalink] [raw]

Subject: Re: [PATCH -next] dmaengine: sun4i: Use list_move_tail instead of list_del/list_add_tail

---

On Mon, Jun 07, 2021 at 11:20:35AM +0800, Zou Wei wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Acked-by: Maxime Ripard <[email protected]>

Thanks!
Maxime

---

Attachments:

(No filename) (289.00 B)
signature.asc (235.00 B)
Download all attachments

2021-06-07 11:41:07

by Vinod Koul

[permalink] [raw]

Subject: Re: [PATCH -next] dmaengine: sun4i: Use list_move_tail instead of list_del/list_add_tail

---

On 07-06-21, 11:20, Zou Wei wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().

Applied, thanks

--
~Vinod