2021-06-01 09:56:39

by Paul Cercueil

Subject: [PATCH] drm: Fix misleading documentation of drm_gem_cma_create()

The backing memory does not necessarily have the writecombine attribute
set, since commit cf8ccbc72d61 ("drm: Add support for GEM buffers backed
by non-coherent memory").

Fixes: cf8ccbc72d61 ("drm: Add support for GEM buffers backed by non-coherent memory")
Signed-off-by: Paul Cercueil <[email protected]>
---
drivers/gpu/drm/drm_gem_cma_helper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
index 4a24af2c5c43..d53388199f34 100644
--- a/drivers/gpu/drm/drm_gem_cma_helper.c
+++ b/drivers/gpu/drm/drm_gem_cma_helper.c
@@ -104,8 +104,7 @@ __drm_gem_cma_create(struct drm_device *drm, size_t size, bool private)
* @size: size of the object to allocate
*
* This function creates a CMA GEM object and allocates a contiguous chunk of
- * memory as backing store. The backing memory has the writecombine attribute
- * set.
+ * memory as backing store.
*
* Returns:
* A struct drm_gem_cma_object * on success or an ERR_PTR()-encoded negative
--
2.30.2

2021-06-01 16:13:48

by Daniel Vetter

Subject: Re: [PATCH] drm: Fix misleading documentation of drm_gem_cma_create()

On Tue, Jun 01, 2021 at 10:54:05AM +0100, Paul Cercueil wrote:
> The backing memory does not necessarily have the writecombine attribute
> set, since commit cf8ccbc72d61 ("drm: Add support for GEM buffers backed
> by non-coherent memory").
>
> Fixes: cf8ccbc72d61 ("drm: Add support for GEM buffers backed by non-coherent memory")
> Signed-off-by: Paul Cercueil <[email protected]>

Acked-by: Daniel Vetter <[email protected]>

> ---
> drivers/gpu/drm/drm_gem_cma_helper.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c b/drivers/gpu/drm/drm_gem_cma_helper.c
> index 4a24af2c5c43..d53388199f34 100644
> --- a/drivers/gpu/drm/drm_gem_cma_helper.c
> +++ b/drivers/gpu/drm/drm_gem_cma_helper.c
> @@ -104,8 +104,7 @@ __drm_gem_cma_create(struct drm_device *drm, size_t size, bool private)
> * @size: size of the object to allocate
> *
> * This function creates a CMA GEM object and allocates a contiguous chunk of
> - * memory as backing store. The backing memory has the writecombine attribute
> - * set.
> + * memory as backing store.
> *
> * Returns:
> * A struct drm_gem_cma_object * on success or an ERR_PTR()-encoded negative
> --
> 2.30.2
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch