From: Marek Vasut <[email protected]>
commit 8967b27a6c1c19251989c7ab33c058d16e4a5f53 upstream.
Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1
via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied
from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs.
While no instability or problems are currently observed, the regulators
should be fully described in DT and that description should fully match
the hardware, else this might lead to unforseen issues later. Fix this.
Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2")
Reviewed-by: Fabio Estevam <[email protected]>
Signed-off-by: Marek Vasut <[email protected]>
Cc: Christoph Niedermaier <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Ludwig Zenz <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
Reviewed-by: Christoph Niedermaier <[email protected]>
Signed-off-by: Shawn Guo <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
--- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
+++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
@@ -407,6 +407,18 @@
vin-supply = <&sw1_reg>;
};
+®_pu {
+ vin-supply = <&sw1_reg>;
+};
+
+®_vdd1p1 {
+ vin-supply = <&sw2_reg>;
+};
+
+®_vdd2p5 {
+ vin-supply = <&sw2_reg>;
+};
+
&uart1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>;
On Wed, 9 Jun 2021 at 00:08, Greg Kroah-Hartman
<[email protected]> wrote:
>
> From: Marek Vasut <[email protected]>
>
> commit 8967b27a6c1c19251989c7ab33c058d16e4a5f53 upstream.
>
> Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1
> via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied
> from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs.
>
> While no instability or problems are currently observed, the regulators
> should be fully described in DT and that description should fully match
> the hardware, else this might lead to unforseen issues later. Fix this.
>
> Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2")
> Reviewed-by: Fabio Estevam <[email protected]>
> Signed-off-by: Marek Vasut <[email protected]>
> Cc: Christoph Niedermaier <[email protected]>
> Cc: Fabio Estevam <[email protected]>
> Cc: Ludwig Zenz <[email protected]>
> Cc: NXP Linux Team <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Cc: [email protected]
> Reviewed-by: Christoph Niedermaier <[email protected]>
> Signed-off-by: Shawn Guo <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> --- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> +++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> @@ -407,6 +407,18 @@
> vin-supply = <&sw1_reg>;
> };
>
> +®_pu {
> + vin-supply = <&sw1_reg>;
> +};
> +
> +®_vdd1p1 {
> + vin-supply = <&sw2_reg>;
> +};
> +
> +®_vdd2p5 {
> + vin-supply = <&sw2_reg>;
> +};
> +
> &uart1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_uart1>;
arm dtb build failed on stable rc 4.19
make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
Error: /builds/linux/arch/arm/boot/dts/imx6q-dhcom-som.dtsi:414.1-12
Label or path reg_vdd1p1 not found
Error: /builds/linux/arch/arm/boot/dts/imx6q-dhcom-som.dtsi:418.1-12
Label or path reg_vdd2p5 not found
FATAL ERROR: Syntax error parsing input tree
make[2]: *** [scripts/Makefile.lib:294:
arch/arm/boot/dts/imx6q-dhcom-pdk2.dtb] Error 1
Reported-by: Linux Kernel Functional Testing <[email protected]>
build url:
https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1328891505#L477
Config:
https://builds.tuxbuild.com/1tg0YjTz4ow5CkHv0bzTc05pVs5/config
--
Linaro LKFT
https://lkft.linaro.org
Hi Greg,
On Tue, Jun 08, 2021 at 08:27:09PM +0200, Greg Kroah-Hartman wrote:
> From: Marek Vasut <[email protected]>
>
> commit 8967b27a6c1c19251989c7ab33c058d16e4a5f53 upstream.
This is causing build failure with error:
Error: arch/arm/boot/dts/imx6q-dhcom-som.dtsi:414.1-12 Label or path reg_vdd1p1 not found
Error: arch/arm/boot/dts/imx6q-dhcom-som.dtsi:418.1-12 Label or path reg_vdd2p5 not found
FATAL ERROR: Syntax error parsing input tree
--
Regards
Sudip
On Tue, Jun 08, 2021 at 08:09:00PM +0100, Sudip Mukherjee wrote:
> Hi Greg,
>
> On Tue, Jun 08, 2021 at 08:27:09PM +0200, Greg Kroah-Hartman wrote:
> > From: Marek Vasut <[email protected]>
> >
> > commit 8967b27a6c1c19251989c7ab33c058d16e4a5f53 upstream.
>
> This is causing build failure with error:
>
> Error: arch/arm/boot/dts/imx6q-dhcom-som.dtsi:414.1-12 Label or path reg_vdd1p1 not found
> Error: arch/arm/boot/dts/imx6q-dhcom-som.dtsi:418.1-12 Label or path reg_vdd2p5 not found
> FATAL ERROR: Syntax error parsing input tree
Thanks for the report will go drop this now...
greg k-h
On Wed, Jun 09, 2021 at 12:43:46AM +0530, Naresh Kamboju wrote:
> On Wed, 9 Jun 2021 at 00:08, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > From: Marek Vasut <[email protected]>
> >
> > commit 8967b27a6c1c19251989c7ab33c058d16e4a5f53 upstream.
> >
> > Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1
> > via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied
> > from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs.
> >
> > While no instability or problems are currently observed, the regulators
> > should be fully described in DT and that description should fully match
> > the hardware, else this might lead to unforseen issues later. Fix this.
> >
> > Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2")
> > Reviewed-by: Fabio Estevam <[email protected]>
> > Signed-off-by: Marek Vasut <[email protected]>
> > Cc: Christoph Niedermaier <[email protected]>
> > Cc: Fabio Estevam <[email protected]>
> > Cc: Ludwig Zenz <[email protected]>
> > Cc: NXP Linux Team <[email protected]>
> > Cc: Shawn Guo <[email protected]>
> > Cc: [email protected]
> > Reviewed-by: Christoph Niedermaier <[email protected]>
> > Signed-off-by: Shawn Guo <[email protected]>
> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > ---
> > arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > --- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> > +++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi
> > @@ -407,6 +407,18 @@
> > vin-supply = <&sw1_reg>;
> > };
> >
> > +®_pu {
> > + vin-supply = <&sw1_reg>;
> > +};
> > +
> > +®_vdd1p1 {
> > + vin-supply = <&sw2_reg>;
> > +};
> > +
> > +®_vdd2p5 {
> > + vin-supply = <&sw2_reg>;
> > +};
> > +
> > &uart1 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_uart1>;
>
> arm dtb build failed on stable rc 4.19
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
> CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
> arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
> Error: /builds/linux/arch/arm/boot/dts/imx6q-dhcom-som.dtsi:414.1-12
> Label or path reg_vdd1p1 not found
> Error: /builds/linux/arch/arm/boot/dts/imx6q-dhcom-som.dtsi:418.1-12
> Label or path reg_vdd2p5 not found
> FATAL ERROR: Syntax error parsing input tree
> make[2]: *** [scripts/Makefile.lib:294:
> arch/arm/boot/dts/imx6q-dhcom-pdk2.dtb] Error 1
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> build url:
> https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1328891505#L477
>
> Config:
> https://builds.tuxbuild.com/1tg0YjTz4ow5CkHv0bzTc05pVs5/config
Thanks, will go delete this and push out a -rc2.
greg k-h