2021-06-28 00:42:02

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH -next] <linux/dma-resv.h>: correct a function name in kernel-doc

Fix kernel-doc function name warning:

../include/linux/dma-resv.h:227: warning: expecting prototype for dma_resv_exclusive(). Prototype was for dma_resv_excl_fence() instead

Fixes: 6edbd6abb783d ("ma-buf: rename and cleanup dma_resv_get_excl v3")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Sumit Semwal <[email protected]>
Cc: Christian König <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
include/linux/dma-resv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210625.orig/include/linux/dma-resv.h
+++ linux-next-20210625/include/linux/dma-resv.h
@@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struc
}

/**
- * dma_resv_exclusive - return the object's exclusive fence
+ * dma_resv_excl_fence - return the object's exclusive fence
* @obj: the reservation object
*
* Returns the exclusive fence (if any). Caller must either hold the objects


2021-06-29 15:59:10

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH -next] <linux/dma-resv.h>: correct a function name in kernel-doc

On Sun, Jun 27, 2021 at 05:40:12PM -0700, Randy Dunlap wrote:
> Fix kernel-doc function name warning:
>
> ../include/linux/dma-resv.h:227: warning: expecting prototype for dma_resv_exclusive(). Prototype was for dma_resv_excl_fence() instead
>
> Fixes: 6edbd6abb783d ("ma-buf: rename and cleanup dma_resv_get_excl v3")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Sumit Semwal <[email protected]>
> Cc: Christian K?nig <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]

Queued up, thanks for your patch (and the handy -next signifier in the
patch tag). I think Christian had the fix for this already, but queued up
in the next branch (for the 5.15 merge window, we're already prepping
stuff there to avoid late feature additions for 5.14), so applied yours
once more to the right tree.

Cheers, Daniel

> ---
> include/linux/dma-resv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210625.orig/include/linux/dma-resv.h
> +++ linux-next-20210625/include/linux/dma-resv.h
> @@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struc
> }
>
> /**
> - * dma_resv_exclusive - return the object's exclusive fence
> + * dma_resv_excl_fence - return the object's exclusive fence
> * @obj: the reservation object
> *
> * Returns the exclusive fence (if any). Caller must either hold the objects

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2021-06-29 17:01:05

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH -next] <linux/dma-resv.h>: correct a function name in kernel-doc

On 6/29/21 9:10 AM, Daniel Vetter wrote:
> On Tue, Jun 29, 2021 at 05:55:15PM +0200, Daniel Vetter wrote:
>> On Sun, Jun 27, 2021 at 05:40:12PM -0700, Randy Dunlap wrote:
>>> Fix kernel-doc function name warning:
>>>
>>> ../include/linux/dma-resv.h:227: warning: expecting prototype for dma_resv_exclusive(). Prototype was for dma_resv_excl_fence() instead
>>>
>>> Fixes: 6edbd6abb783d ("ma-buf: rename and cleanup dma_resv_get_excl v3")
>
> Script caught a lost 'd' here, I fixed that up when applying.
> -Daniel

Oops. Thanks.

~Randy

2021-06-29 17:01:05

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH -next] <linux/dma-resv.h>: correct a function name in kernel-doc

On Tue, Jun 29, 2021 at 05:55:15PM +0200, Daniel Vetter wrote:
> On Sun, Jun 27, 2021 at 05:40:12PM -0700, Randy Dunlap wrote:
> > Fix kernel-doc function name warning:
> >
> > ../include/linux/dma-resv.h:227: warning: expecting prototype for dma_resv_exclusive(). Prototype was for dma_resv_excl_fence() instead
> >
> > Fixes: 6edbd6abb783d ("ma-buf: rename and cleanup dma_resv_get_excl v3")

Script caught a lost 'd' here, I fixed that up when applying.
-Daniel

> > Signed-off-by: Randy Dunlap <[email protected]>
> > Cc: Sumit Semwal <[email protected]>
> > Cc: Christian K?nig <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
>
> Queued up, thanks for your patch (and the handy -next signifier in the
> patch tag). I think Christian had the fix for this already, but queued up
> in the next branch (for the 5.15 merge window, we're already prepping
> stuff there to avoid late feature additions for 5.14), so applied yours
> once more to the right tree.
>
> Cheers, Daniel
>
> > ---
> > include/linux/dma-resv.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-next-20210625.orig/include/linux/dma-resv.h
> > +++ linux-next-20210625/include/linux/dma-resv.h
> > @@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struc
> > }
> >
> > /**
> > - * dma_resv_exclusive - return the object's exclusive fence
> > + * dma_resv_excl_fence - return the object's exclusive fence
> > * @obj: the reservation object
> > *
> > * Returns the exclusive fence (if any). Caller must either hold the objects
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch