2021-07-20 23:07:32

by Takashi Iwai

Subject: REGRESSION: Renesas USB host broken after commit d143825baf15

Hi,

the recent patch landed in 5.13.2 stable tree from the upstream commit
d143825baf15 ("usb: renesas-xhci: Fix handling of unknown ROM state")
seems causing a regression on a few machines, as reported on openSUSE
Bugzilla:
https://bugzilla.opensuse.org/show_bug.cgi?id=1188485
https://bugzilla.opensuse.org/show_bug.cgi?id=1188515

Reverting it on top of 5.13.3 fixed the problem, so it's likely the
cause. Could you guys take a look?


thanks,

Takashi

2021-07-20 23:38:46

by Moritz Fischer

Subject: Re: REGRESSION: Renesas USB host broken after commit d143825baf15

Hi Takashi,

On Wed, Jul 21, 2021 at 01:06:29AM +0200, Takashi Iwai wrote:
> Hi,
>
> the recent patch landed in 5.13.2 stable tree from the upstream commit
> d143825baf15 ("usb: renesas-xhci: Fix handling of unknown ROM state")
> seems causing a regression on a few machines, as reported on openSUSE
> Bugzilla:
> https://bugzilla.opensuse.org/show_bug.cgi?id=1188485
> https://bugzilla.opensuse.org/show_bug.cgi?id=1188515
>
> Reverting it on top of 5.13.3 fixed the problem, so it's likely the
> cause. Could you guys take a look?

I've sent out a revert patch.

https://lore.kernel.org/linux-usb/[email protected]/T/#u

I think the driver has more problems but I'll tackle that in a follow up
patch, lets get this unbricked, first.

Sorry for the inconvenience,

Moritz

2021-07-21 07:27:29

by Takashi Iwai

Subject: Re: REGRESSION: Renesas USB host broken after commit d143825baf15

On Wed, 21 Jul 2021 01:29:22 +0200,
Moritz Fischer wrote:
>
> Hi Takashi,
>
> On Wed, Jul 21, 2021 at 01:06:29AM +0200, Takashi Iwai wrote:
> > Hi,
> >
> > the recent patch landed in 5.13.2 stable tree from the upstream commit
> > d143825baf15 ("usb: renesas-xhci: Fix handling of unknown ROM state")
> > seems causing a regression on a few machines, as reported on openSUSE
> > Bugzilla:
> > https://bugzilla.opensuse.org/show_bug.cgi?id=1188485
> > https://bugzilla.opensuse.org/show_bug.cgi?id=1188515
> >
> > Reverting it on top of 5.13.3 fixed the problem, so it's likely the
> > cause. Could you guys take a look?
>
> I've sent out a revert patch.
>
> https://lore.kernel.org/linux-usb/[email protected]/T/#u
>
> I think the driver has more problems but I'll tackle that in a follow up
> patch, lets get this unbricked, first.

OK, thank you for the information!


Takashi

2021-07-21 07:59:51

by Greg Kroah-Hartman

Subject: Re: REGRESSION: Renesas USB host broken after commit d143825baf15

On Wed, Jul 21, 2021 at 09:20:38AM +0200, Takashi Iwai wrote:
> On Wed, 21 Jul 2021 01:29:22 +0200,
> Moritz Fischer wrote:
> >
> > Hi Takashi,
> >
> > On Wed, Jul 21, 2021 at 01:06:29AM +0200, Takashi Iwai wrote:
> > > Hi,
> > >
> > > the recent patch landed in 5.13.2 stable tree from the upstream commit
> > > d143825baf15 ("usb: renesas-xhci: Fix handling of unknown ROM state")
> > > seems causing a regression on a few machines, as reported on openSUSE
> > > Bugzilla:
> > > https://bugzilla.opensuse.org/show_bug.cgi?id=1188485
> > > https://bugzilla.opensuse.org/show_bug.cgi?id=1188515
> > >
> > > Reverting it on top of 5.13.3 fixed the problem, so it's likely the
> > > cause. Could you guys take a look?
> >
> > I've sent out a revert patch.
> >
> > https://lore.kernel.org/linux-usb/[email protected]/T/#u
> >
> > I think the driver has more problems but I'll tackle that in a follow up
> > patch, lets get this unbricked, first.
>
> OK, thank you for the information!

I've reverted this now, will get it to Linus for 5.14-rc3, sorry about
that.

thanks,

greg k-h