2021-07-22 19:00:58

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH] percpu: remove export of pcpu_base_addr

This is not needed by any modules, so remove the export.

Cc: Dennis Zhou <[email protected]>
Cc: Tejun Heo <[email protected]>
Cc: Christoph Lameter <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
mm/percpu.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/mm/percpu.c b/mm/percpu.c
index 7f2e0151c4e2..a43039629aa4 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -146,7 +146,6 @@ static unsigned int pcpu_high_unit_cpu __ro_after_init;

/* the address of the first chunk which starts with the kernel static area */
void *pcpu_base_addr __ro_after_init;
-EXPORT_SYMBOL_GPL(pcpu_base_addr);

static const int *pcpu_unit_map __ro_after_init; /* cpu -> unit */
const unsigned long *pcpu_unit_offsets __ro_after_init; /* cpu -> unit offset */
--
2.32.0


2021-07-23 05:39:53

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] percpu: remove export of pcpu_base_addr

On Thu, Jul 22, 2021 at 08:58:14PM +0200, Greg Kroah-Hartman wrote:
> This is not needed by any modules, so remove the export.

Looks good. Note that all non-static users only want the delta,
so this could be cleaned up with a helper as well. Also
__addr_to_pcpu_ptr and __pcpu_ptr_to_addr__pcpu_ptr_to_addr are
never actually overriden by arch code, so we can remove the ifndef
there.

Reviewed-by: Christoph Hellwig <[email protected]>