2021-07-22 06:46:44

by Leon Romanovsky

[permalink] [raw]
Subject: [PATCH rdma-next] docs: Fix infiniband uverbs minor number

From: Leon Romanovsky <[email protected]>

Starting from the introduction of infiniband subsystem, the uverbs
char devices started from 192 as a minor number, see
commit bc38a6abdd5a ("[PATCH] IB uverbs: core implementation"), but
the documentation was slightly different.

This patch updates the admin guide documentation to reflect it.

Fixes: 9d85025b0418 ("docs-rst: create an user's manual book")
Signed-off-by: Leon Romanovsky <[email protected]>
---
Documentation/admin-guide/devices.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-guide/devices.txt
index 9c2be821c225..922c23bb4372 100644
--- a/Documentation/admin-guide/devices.txt
+++ b/Documentation/admin-guide/devices.txt
@@ -2993,10 +2993,10 @@
65 = /dev/infiniband/issm1 Second InfiniBand IsSM device
...
127 = /dev/infiniband/issm63 63rd InfiniBand IsSM device
- 128 = /dev/infiniband/uverbs0 First InfiniBand verbs device
- 129 = /dev/infiniband/uverbs1 Second InfiniBand verbs device
+ 192 = /dev/infiniband/uverbs0 First InfiniBand verbs device
+ 193 = /dev/infiniband/uverbs1 Second InfiniBand verbs device
...
- 159 = /dev/infiniband/uverbs31 31st InfiniBand verbs device
+ 223 = /dev/infiniband/uverbs31 31st InfiniBand verbs device

232 char Biometric Devices
0 = /dev/biometric/sensor0/fingerprint first fingerprint sensor on first device
--
2.31.1


2021-07-23 13:57:29

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH rdma-next] docs: Fix infiniband uverbs minor number

+ RDMA

On Thu, Jul 22, 2021 at 09:45:07AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <[email protected]>
>
> Starting from the introduction of infiniband subsystem, the uverbs
> char devices started from 192 as a minor number, see
> commit bc38a6abdd5a ("[PATCH] IB uverbs: core implementation"), but
> the documentation was slightly different.
>
> This patch updates the admin guide documentation to reflect it.
>
> Fixes: 9d85025b0418 ("docs-rst: create an user's manual book")
> Signed-off-by: Leon Romanovsky <[email protected]>
> ---
> Documentation/admin-guide/devices.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-guide/devices.txt
> index 9c2be821c225..922c23bb4372 100644
> --- a/Documentation/admin-guide/devices.txt
> +++ b/Documentation/admin-guide/devices.txt
> @@ -2993,10 +2993,10 @@
> 65 = /dev/infiniband/issm1 Second InfiniBand IsSM device
> ...
> 127 = /dev/infiniband/issm63 63rd InfiniBand IsSM device
> - 128 = /dev/infiniband/uverbs0 First InfiniBand verbs device
> - 129 = /dev/infiniband/uverbs1 Second InfiniBand verbs device
> + 192 = /dev/infiniband/uverbs0 First InfiniBand verbs device
> + 193 = /dev/infiniband/uverbs1 Second InfiniBand verbs device
> ...
> - 159 = /dev/infiniband/uverbs31 31st InfiniBand verbs device
> + 223 = /dev/infiniband/uverbs31 31st InfiniBand verbs device
>
> 232 char Biometric Devices
> 0 = /dev/biometric/sensor0/fingerprint first fingerprint sensor on first device
> --
> 2.31.1
>

2021-07-28 11:56:49

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH rdma-next] docs: Fix infiniband uverbs minor number

Jason ????

On Fri, Jul 23, 2021 at 04:52:34PM +0300, Leon Romanovsky wrote:
> + RDMA
>
> On Thu, Jul 22, 2021 at 09:45:07AM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <[email protected]>
> >
> > Starting from the introduction of infiniband subsystem, the uverbs
> > char devices started from 192 as a minor number, see
> > commit bc38a6abdd5a ("[PATCH] IB uverbs: core implementation"), but
> > the documentation was slightly different.
> >
> > This patch updates the admin guide documentation to reflect it.
> >
> > Fixes: 9d85025b0418 ("docs-rst: create an user's manual book")
> > Signed-off-by: Leon Romanovsky <[email protected]>
> > ---
> > Documentation/admin-guide/devices.txt | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/admin-guide/devices.txt b/Documentation/admin-guide/devices.txt
> > index 9c2be821c225..922c23bb4372 100644
> > --- a/Documentation/admin-guide/devices.txt
> > +++ b/Documentation/admin-guide/devices.txt
> > @@ -2993,10 +2993,10 @@
> > 65 = /dev/infiniband/issm1 Second InfiniBand IsSM device
> > ...
> > 127 = /dev/infiniband/issm63 63rd InfiniBand IsSM device
> > - 128 = /dev/infiniband/uverbs0 First InfiniBand verbs device
> > - 129 = /dev/infiniband/uverbs1 Second InfiniBand verbs device
> > + 192 = /dev/infiniband/uverbs0 First InfiniBand verbs device
> > + 193 = /dev/infiniband/uverbs1 Second InfiniBand verbs device
> > ...
> > - 159 = /dev/infiniband/uverbs31 31st InfiniBand verbs device
> > + 223 = /dev/infiniband/uverbs31 31st InfiniBand verbs device
> >
> > 232 char Biometric Devices
> > 0 = /dev/biometric/sensor0/fingerprint first fingerprint sensor on first device
> > --
> > 2.31.1
> >

2021-07-28 12:01:55

by Jason Gunthorpe

[permalink] [raw]
Subject: Re: [PATCH rdma-next] docs: Fix infiniband uverbs minor number

On Wed, Jul 28, 2021 at 02:53:10PM +0300, Leon Romanovsky wrote:
> Jason ????

I don't know what happened here, but it is not in patchworks

The patch looks fine unless there are remarks from the docs people -
please get it in patchworks

Jason

2021-07-28 13:07:08

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH rdma-next] docs: Fix infiniband uverbs minor number

On Wed, Jul 28, 2021 at 08:59:33AM -0300, Jason Gunthorpe wrote:
> On Wed, Jul 28, 2021 at 02:53:10PM +0300, Leon Romanovsky wrote:
> > Jason ????
>
> I don't know what happened here, but it is not in patchworks
>
> The patch looks fine unless there are remarks from the docs people -
> please get it in patchworks

Done,
https://patchwork.kernel.org/project/linux-rdma/patch/bad03e6bcde45550c01e12908a6fe7dfa4770703.1627477347.git.leonro@nvidia.com/

>
> Jason