2021-10-19 12:07:17

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [RFC PATCH 1/1] ACPI / PMIC: Add i2c address to intel_pmic_bytcrc driver

On Tue, Oct 19, 2021 at 08:56:04PM +0900, Tsuchiya Yuto wrote:
> On Mon, 2021-10-18 at 11:16 +0200, Hans de Goede wrote:
> > On 10/17/21 18:15, Tsuchiya Yuto wrote:

...

> > Tsuchiya, can you give the attached patch a try.
>
> Thanks!
>
> I tried your attached patch, and I can confirm that it's working as
> expected.
>
> Now it's using cht one:
>
> $ ls /sys/devices/pci0000:00/808622C1:05/i2c-5/i2c-INT33FD:00
> cht_crystal_cove_pmic crystal_cove_gpio crystal_cove_pwm driver firmware_node modalias name power subsystem uevent
>
> and the function intel_soc_pmic_exec_mipi_pmic_seq_element() is also
> working with atomisp driver.

To be formal you may give a dedicated tag here, i.e. Tested-by:.
It will be easier for tools, such as `b4`, to catch it up
and not forget.

--
With Best Regards,
Andy Shevchenko