2021-10-19 15:57:42

by Martin Kepplinger

Subject: [PATCH v3 0/2] media: hi846: minor build fixes

Similar to many other drivers this basically should fix the build warning
where the const struct of_device_id we define can be unused. Reported
here:
https://lore.kernel.org/linux-media/[email protected]/


revision history
----------------
v3: (thank you Sakari)
* include property.h instead of of_graph.h and remove the of_match_ptr macro

v2 and v1:
https://lore.kernel.org/linux-media/[email protected]/

Martin Kepplinger (2):
media: hi846: include property.h instead of of_graph.h
media: hi846: remove the of_match_ptr macro

drivers/media/i2c/hi846.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--
2.30.2

2021-10-19 15:58:43

by Martin Kepplinger

Subject: [PATCH v3 2/2] media: hi846: remove the of_match_ptr macro

Similar to other drivers, this should fix a Clang compilar warning when
building without CONFIG_OF in which case of_match_ptr() is NULL and
the const struct we would use otherwise is unused.

Signed-off-by: Martin Kepplinger <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
drivers/media/i2c/hi846.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c
index 614d55932903..48909faeced4 100644
--- a/drivers/media/i2c/hi846.c
+++ b/drivers/media/i2c/hi846.c
@@ -2176,7 +2176,7 @@ static struct i2c_driver hi846_i2c_driver = {
.driver = {
.name = "hi846",
.pm = &hi846_pm_ops,
- .of_match_table = of_match_ptr(hi846_of_match),
+ .of_match_table = hi846_of_match,
},
.probe_new = hi846_probe,
.remove = hi846_remove,
--
2.30.2

2021-10-20 13:00:32

by Sakari Ailus

Subject: Re: [PATCH v3 0/2] media: hi846: minor build fixes

On Tue, Oct 19, 2021 at 05:55:07PM +0200, Martin Kepplinger wrote:
> Similar to many other drivers this basically should fix the build warning
> where the const struct of_device_id we define can be unused. Reported
> here:
> https://lore.kernel.org/linux-media/[email protected]/

Thanks, Martin!>

--
Sakari Ailus

2021-11-04 10:58:17

by Martin Kepplinger

Subject: Re: [PATCH v3 0/2] media: hi846: minor build fixes

Am Mittwoch, dem 20.10.2021 um 15:57 +0300 schrieb Sakari Ailus:
> On Tue, Oct 19, 2021 at 05:55:07PM +0200, Martin Kepplinger wrote:
> > Similar to many other drivers this basically should fix the build
> > warning
> > where the const struct of_device_id we define can be unused.
> > Reported
> > here:
> > https://lore.kernel.org/linux-media/[email protected]/
>
> Thanks, Martin!>
>

since the Intel test robot just reminded me that the issue still
remains: are these patches queued somewhere already?

thanks!
martin

2021-11-05 09:10:11

by Sakari Ailus

Subject: Re: [PATCH v3 0/2] media: hi846: minor build fixes

Hi Martin,

On Thu, Nov 04, 2021 at 11:53:08AM +0100, Martin Kepplinger wrote:
> Am Mittwoch, dem 20.10.2021 um 15:57 +0300 schrieb Sakari Ailus:
> > On Tue, Oct 19, 2021 at 05:55:07PM +0200, Martin Kepplinger wrote:
> > > Similar to many other drivers this basically should fix the build
> > > warning
> > > where the const struct of_device_id we define can be unused.
> > > Reported
> > > here:
> > > https://lore.kernel.org/linux-media/[email protected]/
> >
> > Thanks, Martin!>
> >
>
> since the Intel test robot just reminded me that the issue still
> remains: are these patches queued somewhere already?

Not yet. And thanks for the ping. I had forgotten about these fixes and
wrote a fix for the same issue, so I'm taking these two instead.

--
Sakari Ailus