2022-02-17 15:50:47

by Ville Syrjälä

Subject: Re: [Intel-gfx] [PATCH 6/9] drm/i915: Separate wakeref tracking

On Thu, Feb 17, 2022 at 03:04:38PM +0100, Andrzej Hajda wrote:
> -static noinline depot_stack_handle_t
> +static intel_wakeref_t
> track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
> {
> - depot_stack_handle_t stack, *stacks;
> - unsigned long flags;
> -
> - if (rpm->no_wakeref_tracking)
> - return -1;
> -
> - stack = __save_depot_stack();
> - if (!stack)
> + if (!rpm->available)
> return -1;

no_wakeref_tracking != available

--
Ville Syrj?l?
Intel

2022-02-18 11:09:19

by Andrzej Hajda

Subject: Re: [Intel-gfx] [PATCH 6/9] drm/i915: Separate wakeref tracking

On 17.02.2022 15:48, Ville Syrjälä wrote:
> On Thu, Feb 17, 2022 at 03:04:38PM +0100, Andrzej Hajda wrote:
>> -static noinline depot_stack_handle_t
>> +static intel_wakeref_t
>> track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
>> {
>> - depot_stack_handle_t stack, *stacks;
>> - unsigned long flags;
>> -
>> - if (rpm->no_wakeref_tracking)
>> - return -1;
>> -
>> - stack = __save_depot_stack();
>> - if (!stack)
>> + if (!rpm->available)
>> return -1;
> no_wakeref_tracking != available

ups I missed this change, will be more careful in next iteration.

Regards
Andrzej