2021-12-28 04:58:38

by Bjorn Andersson

Subject: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350

The Qualcomm SM8350 platform comes with a single DisplayPort controller,
add support for this in the DisplayPort driver.

Signed-off-by: Bjorn Andersson <[email protected]>
---
.../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
2 files changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 5457612ab136..cd05cfd76536 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -21,6 +21,7 @@ properties:
- qcom,sc7280-edp
- qcom,sc8180x-dp
- qcom,sc8180x-edp
+ - qcom,sm8350-dp

reg:
items:
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 8d9c19dbf33e..fd0fd03f8fed 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = {
.num_descs = 2,
};

+static const struct msm_dp_config sm8350_dp_cfg = {
+ .descs = (const struct msm_dp_desc[]) {
+ [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort },
+ },
+ .num_descs = 1,
+};
+
static const struct of_device_id dp_dt_match[] = {
{ .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
{ .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
{ .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
+ { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg },
{}
};

--
2.33.1

2022-01-10 18:03:15

by Rob Herring (Arm)

Subject: Re: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350

On Mon, 27 Dec 2021 20:59:34 -0800, Bjorn Andersson wrote:
> The Qualcomm SM8350 platform comes with a single DisplayPort controller,
> add support for this in the DisplayPort driver.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> .../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
> drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
> 2 files changed, 9 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2022-01-21 20:10:50

by Dmitry Baryshkov

Subject: Re: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350

On 28/12/2021 07:59, Bjorn Andersson wrote:
> The Qualcomm SM8350 platform comes with a single DisplayPort controller,
> add support for this in the DisplayPort driver.
>
> Signed-off-by: Bjorn Andersson <[email protected]>

Reviewed-by: Dmitry Baryshkov <[email protected]>

> ---
> .../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
> drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 5457612ab136..cd05cfd76536 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -21,6 +21,7 @@ properties:
> - qcom,sc7280-edp
> - qcom,sc8180x-dp
> - qcom,sc8180x-edp
> + - qcom,sm8350-dp
>
> reg:
> items:
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index 8d9c19dbf33e..fd0fd03f8fed 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = {
> .num_descs = 2,
> };
>
> +static const struct msm_dp_config sm8350_dp_cfg = {
> + .descs = (const struct msm_dp_desc[]) {
> + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort },
> + },
> + .num_descs = 1,
> +};
> +
> static const struct of_device_id dp_dt_match[] = {
> { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
> { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
> + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg },
> {}
> };
>


--
With best wishes
Dmitry

2022-02-09 09:54:43

by Dmitry Baryshkov

Subject: Re: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350

On Wed, 9 Feb 2022 at 00:21, Bjorn Andersson <[email protected]> wrote:
>
> On Wed 19 Jan 15:14 PST 2022, Dmitry Baryshkov wrote:
>
> > On 28/12/2021 07:59, Bjorn Andersson wrote:
> > > The Qualcomm SM8350 platform comes with a single DisplayPort controller,
> > > add support for this in the DisplayPort driver.
> > >
> > > Signed-off-by: Bjorn Andersson <[email protected]>
> >
> > Reviewed-by: Dmitry Baryshkov <[email protected]>
> >
>
> I don't see this in linux-next, would it be possible to pick it up now
> that we're past the merge window etc?

I'll work on my staging tree (and send it to Rob) before the EoW.

>
> Regards,
> Bjorn
>
> > > ---
> > > .../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
> > > drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
> > > 2 files changed, 9 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > index 5457612ab136..cd05cfd76536 100644
> > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > > @@ -21,6 +21,7 @@ properties:
> > > - qcom,sc7280-edp
> > > - qcom,sc8180x-dp
> > > - qcom,sc8180x-edp
> > > + - qcom,sm8350-dp
> > > reg:
> > > items:
> > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> > > index 8d9c19dbf33e..fd0fd03f8fed 100644
> > > --- a/drivers/gpu/drm/msm/dp/dp_display.c
> > > +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> > > @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = {
> > > .num_descs = 2,
> > > };
> > > +static const struct msm_dp_config sm8350_dp_cfg = {
> > > + .descs = (const struct msm_dp_desc[]) {
> > > + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort },
> > > + },
> > > + .num_descs = 1,
> > > +};
> > > +
> > > static const struct of_device_id dp_dt_match[] = {
> > > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> > > { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
> > > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
> > > + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg },
> > > {}
> > > };
> >
> >
> > --
> > With best wishes
> > Dmitry



--
With best wishes
Dmitry

2022-02-09 12:01:06

by Bjorn Andersson

Subject: Re: [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350

On Wed 19 Jan 15:14 PST 2022, Dmitry Baryshkov wrote:

> On 28/12/2021 07:59, Bjorn Andersson wrote:
> > The Qualcomm SM8350 platform comes with a single DisplayPort controller,
> > add support for this in the DisplayPort driver.
> >
> > Signed-off-by: Bjorn Andersson <[email protected]>
>
> Reviewed-by: Dmitry Baryshkov <[email protected]>
>

I don't see this in linux-next, would it be possible to pick it up now
that we're past the merge window etc?

Regards,
Bjorn

> > ---
> > .../devicetree/bindings/display/msm/dp-controller.yaml | 1 +
> > drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++++++
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > index 5457612ab136..cd05cfd76536 100644
> > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> > @@ -21,6 +21,7 @@ properties:
> > - qcom,sc7280-edp
> > - qcom,sc8180x-dp
> > - qcom,sc8180x-edp
> > + - qcom,sm8350-dp
> > reg:
> > items:
> > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> > index 8d9c19dbf33e..fd0fd03f8fed 100644
> > --- a/drivers/gpu/drm/msm/dp/dp_display.c
> > +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> > @@ -143,10 +143,18 @@ static const struct msm_dp_config sc7280_dp_cfg = {
> > .num_descs = 2,
> > };
> > +static const struct msm_dp_config sm8350_dp_cfg = {
> > + .descs = (const struct msm_dp_desc[]) {
> > + [MSM_DP_CONTROLLER_0] = { .io_start = 0x0ae90000, .connector_type = DRM_MODE_CONNECTOR_DisplayPort },
> > + },
> > + .num_descs = 1,
> > +};
> > +
> > static const struct of_device_id dp_dt_match[] = {
> > { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> > { .compatible = "qcom,sc7280-dp", .data = &sc7280_dp_cfg },
> > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_cfg },
> > + { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_cfg },
> > {}
> > };
>
>
> --
> With best wishes
> Dmitry