2022-01-31 11:37:29

by Corentin LABBE

Subject: [PATCH] dt-bindings: watchdog: convert faraday,ftwdt010 to yaml

Converts watchdog/faraday,ftwdt010.txt to yaml.
This permits to detect missing properties like clocks and resets or
compatible like moxa,moxart-watchdog.

Signed-off-by: Corentin Labbe <[email protected]>
---
.../bindings/watchdog/faraday,ftwdt010.txt | 22 -------
.../bindings/watchdog/faraday,ftwdt010.yaml | 60 +++++++++++++++++++
2 files changed, 60 insertions(+), 22 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml

diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
deleted file mode 100644
index 9ecdb502e605..000000000000
--- a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-Faraday Technology FTWDT010 watchdog
-
-This is an IP part from Faraday Technology found in the Gemini
-SoCs and others.
-
-Required properties:
-- compatible : must be one of
- "faraday,ftwdt010"
- "cortina,gemini-watchdog", "faraday,ftwdt010"
-- reg : shall contain base register location and length
-- interrupts : shall contain the interrupt for the watchdog
-
-Optional properties:
-- timeout-sec : the default watchdog timeout in seconds.
-
-Example:
-
-watchdog@41000000 {
- compatible = "faraday,ftwdt010";
- reg = <0x41000000 0x1000>;
- interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
-};
diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
new file mode 100644
index 000000000000..377529b21267
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/faraday,ftwdt010.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Faraday Technology FTWDT010 watchdog
+
+maintainers:
+ - Linus Walleij <[email protected]>
+
+description: |
+ This is an IP part from Faraday Technology found in the Gemini
+ SoCs and others.
+
+properties:
+ compatible:
+ oneOf:
+ - const: "faraday,ftwdt010"
+ - items:
+ - const: "cortina,gemini-watchdog"
+ - const: "faraday,ftwdt010"
+ - items:
+ - const: "moxa,moxart-watchdog"
+ - const: "faraday,ftwdt010"
+ reg:
+ maxItems: 1
+ resets:
+ maxItems: 1
+ clocks:
+ maxItems: 1
+ clock-names:
+ const: PCLK
+ interrupts:
+ maxItems: 1
+ timeout-sec:
+ description: the default watchdog timeout in seconds.
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ watchdog@41000000 {
+ compatible = "faraday,ftwdt010";
+ reg = <0x41000000 0x1000>;
+ interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ - |
+ watchdog: watchdog@98500000 {
+ compatible = "moxa,moxart-watchdog", "faraday,ftwdt010";
+ reg = <0x98500000 0x10>;
+ clocks = <&clk_apb>;
+ clock-names = "PCLK";
+ };
+...
--
2.34.1

2022-01-31 22:35:19

by Linus Walleij

Subject: Re: [PATCH] dt-bindings: watchdog: convert faraday,ftwdt010 to yaml

On Fri, Jan 28, 2022 at 9:49 PM Corentin Labbe <[email protected]> wrote:

> Converts watchdog/faraday,ftwdt010.txt to yaml.
> This permits to detect missing properties like clocks and resets or
> compatible like moxa,moxart-watchdog.
>
> Signed-off-by: Corentin Labbe <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

+maintainers:
+ - Linus Walleij <[email protected]>

It's fine if you also add yourself on these, the more maintainers
the better.

Yours,
Linus Walleij

2022-02-10 02:07:43

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: watchdog: convert faraday,ftwdt010 to yaml

On Fri, Jan 28, 2022 at 08:48:56PM +0000, Corentin Labbe wrote:
> Converts watchdog/faraday,ftwdt010.txt to yaml.
> This permits to detect missing properties like clocks and resets or
> compatible like moxa,moxart-watchdog.
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> .../bindings/watchdog/faraday,ftwdt010.txt | 22 -------
> .../bindings/watchdog/faraday,ftwdt010.yaml | 60 +++++++++++++++++++
> 2 files changed, 60 insertions(+), 22 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
> deleted file mode 100644
> index 9ecdb502e605..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -Faraday Technology FTWDT010 watchdog
> -
> -This is an IP part from Faraday Technology found in the Gemini
> -SoCs and others.
> -
> -Required properties:
> -- compatible : must be one of
> - "faraday,ftwdt010"
> - "cortina,gemini-watchdog", "faraday,ftwdt010"
> -- reg : shall contain base register location and length
> -- interrupts : shall contain the interrupt for the watchdog
> -
> -Optional properties:
> -- timeout-sec : the default watchdog timeout in seconds.
> -
> -Example:
> -
> -watchdog@41000000 {
> - compatible = "faraday,ftwdt010";
> - reg = <0x41000000 0x1000>;
> - interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> -};
> diff --git a/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> new file mode 100644
> index 000000000000..377529b21267
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/faraday,ftwdt010.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Faraday Technology FTWDT010 watchdog
> +
> +maintainers:
> + - Linus Walleij <[email protected]>
> +
> +description: |
> + This is an IP part from Faraday Technology found in the Gemini
> + SoCs and others.
> +

Need a $ref to watchdog.yaml

> +properties:
> + compatible:
> + oneOf:
> + - const: "faraday,ftwdt010"
> + - items:
> + - const: "cortina,gemini-watchdog"
> + - const: "faraday,ftwdt010"
> + - items:
> + - const: "moxa,moxart-watchdog"
> + - const: "faraday,ftwdt010"

Don't need quotes

blank line

> + reg:
> + maxItems: 1

blank line...

> + resets:
> + maxItems: 1
> + clocks:
> + maxItems: 1
> + clock-names:
> + const: PCLK
> + interrupts:
> + maxItems: 1
> + timeout-sec:
> + description: the default watchdog timeout in seconds.

Don't need to describe common properties.

> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + watchdog@41000000 {
> + compatible = "faraday,ftwdt010";
> + reg = <0x41000000 0x1000>;
> + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + - |
> + watchdog: watchdog@98500000 {
> + compatible = "moxa,moxart-watchdog", "faraday,ftwdt010";
> + reg = <0x98500000 0x10>;
> + clocks = <&clk_apb>;
> + clock-names = "PCLK";
> + };
> +...
> --
> 2.34.1
>
>