2022-03-31 02:28:00

by Ben Gardon

Subject: [PATCH v3 05/11] KVM: selftests: Improve error message in vm_phy_pages_alloc

Make an error message in vm_phy_pages_alloc more specific, and log the
number of pages requested in the allocation.

Signed-off-by: Ben Gardon <[email protected]>
---
tools/testing/selftests/kvm/lib/kvm_util.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
index 09742a787546..9d72d1bb34fa 100644
--- a/tools/testing/selftests/kvm/lib/kvm_util.c
+++ b/tools/testing/selftests/kvm/lib/kvm_util.c
@@ -2408,9 +2408,10 @@ vm_paddr_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num,
} while (pg && pg != base + num);

if (pg == 0) {
- fprintf(stderr, "No guest physical page available, "
+ fprintf(stderr,
+ "Unable to find %ld contiguous guest physical pages. "
"paddr_min: 0x%lx page_size: 0x%x memslot: %u\n",
- paddr_min, vm->page_size, memslot);
+ num, paddr_min, vm->page_size, memslot);
fputs("---- vm dump ----\n", stderr);
vm_dump(stderr, vm, 2);
abort();
--
2.35.1.1021.g381101b075-goog

2022-04-06 05:38:54

by David Matlack

Subject: Re: [PATCH v3 05/11] KVM: selftests: Improve error message in vm_phy_pages_alloc

On Wed, Mar 30, 2022 at 10:46:15AM -0700, Ben Gardon wrote:
> Make an error message in vm_phy_pages_alloc more specific, and log the

vm_phy_pages_alloc()

> number of pages requested in the allocation.
>
> Signed-off-by: Ben Gardon <[email protected]>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index 09742a787546..9d72d1bb34fa 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -2408,9 +2408,10 @@ vm_paddr_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num,
> } while (pg && pg != base + num);
>
> if (pg == 0) {
> - fprintf(stderr, "No guest physical page available, "
> + fprintf(stderr,
> + "Unable to find %ld contiguous guest physical pages. "
> "paddr_min: 0x%lx page_size: 0x%x memslot: %u\n",
> - paddr_min, vm->page_size, memslot);
> + num, paddr_min, vm->page_size, memslot);
> fputs("---- vm dump ----\n", stderr);
> vm_dump(stderr, vm, 2);
> abort();
> --
> 2.35.1.1021.g381101b075-goog
>