2022-04-12 20:38:43

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [RFC PATCH v2 2/6] dt-bindings: opp: accept array of frequencies

Devices might need to control several clocks when scaling the frequency
and voltage. Allow passing array of clock frequencies, similarly to the
voltages.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
index 76c8acd981b3..1d7216008f95 100644
--- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
+++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
@@ -50,6 +50,14 @@ patternProperties:
property to uniquely identify the OPP nodes exists. Devices like power
domains must have another (implementation dependent) property.

+ This can be also an array of frequencies for each clock provided to the
+ device. In such case value of 0 means the clock frequency should not
+ be configured for given clock.
+ minItems: 1
+ maxItems: 16
+ items:
+ maxItems: 1
+
opp-microvolt:
description: |
Voltage for the OPP
--
2.32.0


2022-04-12 22:45:09

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [RFC PATCH v2 2/6] dt-bindings: opp: accept array of frequencies

On Mon 11 Apr 08:43 PDT 2022, Krzysztof Kozlowski wrote:

> Devices might need to control several clocks when scaling the frequency
> and voltage. Allow passing array of clock frequencies, similarly to the
> voltages.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

> ---
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index 76c8acd981b3..1d7216008f95 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -50,6 +50,14 @@ patternProperties:
> property to uniquely identify the OPP nodes exists. Devices like power
> domains must have another (implementation dependent) property.
>
> + This can be also an array of frequencies for each clock provided to the
> + device. In such case value of 0 means the clock frequency should not
> + be configured for given clock.
> + minItems: 1
> + maxItems: 16
> + items:
> + maxItems: 1
> +
> opp-microvolt:
> description: |
> Voltage for the OPP
> --
> 2.32.0
>

2022-04-22 17:44:51

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [RFC PATCH v2 2/6] dt-bindings: opp: accept array of frequencies

On Mon, 11 Apr 2022 17:43:43 +0200, Krzysztof Kozlowski wrote:
> Devices might need to control several clocks when scaling the frequency
> and voltage. Allow passing array of clock frequencies, similarly to the
> voltages.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>

Acked-by: Rob Herring <[email protected]>