2022-04-15 16:13:31

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 4.19 208/338] ARM: ftrace: avoid redundant loads or clobbering IP

On Thu, Apr 14, 2022 at 03:25:29PM +0200, Ard Biesheuvel wrote:
> On Thu, 14 Apr 2022 at 15:23, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > From: Ard Biesheuvel <[email protected]>
> >
> > [ Upstream commit d11967870815b5ab89843980e35aab616c97c463 ]
> >
>
> NAK. Please don't backport these patches to -stable, I thought I had
> been clear on this.

I dropped the patches you asked to be dropped, but this is a different
one and is already in the following releases:
5.10.110 5.15.33 5.16.19 5.17.2

I can also drop it from here and the 5.4 queue if you do not want it
there.

thanks,

greg k-h


2022-04-16 00:30:27

by Ard Biesheuvel

[permalink] [raw]
Subject: Re: [PATCH 4.19 208/338] ARM: ftrace: avoid redundant loads or clobbering IP

On Thu, 14 Apr 2022 at 15:57, Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Thu, Apr 14, 2022 at 03:25:29PM +0200, Ard Biesheuvel wrote:
> > On Thu, 14 Apr 2022 at 15:23, Greg Kroah-Hartman
> > <[email protected]> wrote:
> > >
> > > From: Ard Biesheuvel <[email protected]>
> > >
> > > [ Upstream commit d11967870815b5ab89843980e35aab616c97c463 ]
> > >
> >
> > NAK. Please don't backport these patches to -stable, I thought I had
> > been clear on this.
>
> I dropped the patches you asked to be dropped, but this is a different
> one and is already in the following releases:
> 5.10.110 5.15.33 5.16.19 5.17.2
>
> I can also drop it from here and the 5.4 queue if you do not want it
> there.
>

This is not how I remember it:

On Tue, 5 Apr 2022 at 18:52, Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Tue, Apr 05, 2022 at 12:01:19PM +0200, Ard Biesheuvel wrote:
> > On Tue, 5 Apr 2022 at 11:54, Greg Kroah-Hartman
> > <[email protected]> wrote:
> > >
> > > From: Ard Biesheuvel <[email protected]>
> > >
> > > [ Upstream commit d11967870815b5ab89843980e35aab616c97c463 ]
> > >
..
> >
> > Please drop all the 32-bit ARM patches authored by me from the stable
> > queues except the ones that have fixes tags. These are highly likely
> > to cause an explosion of regressions, and they should have never been
> > selected, as I don't remember anyone proposing these for stable.
>
> From what I can tell, that is only this commit. I'll go drop it from
> all trees, thanks.
>

Can you *please* exclude all patches authored by me from consideration
by this bot? Consider this a blanket NAK to all AUTOSEL patches cc'ed
to me.

2022-04-16 01:10:29

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 4.19 208/338] ARM: ftrace: avoid redundant loads or clobbering IP

On Thu, Apr 14, 2022 at 04:13:06PM +0200, Ard Biesheuvel wrote:
> On Thu, 14 Apr 2022 at 15:57, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > On Thu, Apr 14, 2022 at 03:25:29PM +0200, Ard Biesheuvel wrote:
> > > On Thu, 14 Apr 2022 at 15:23, Greg Kroah-Hartman
> > > <[email protected]> wrote:
> > > >
> > > > From: Ard Biesheuvel <[email protected]>
> > > >
> > > > [ Upstream commit d11967870815b5ab89843980e35aab616c97c463 ]
> > > >
> > >
> > > NAK. Please don't backport these patches to -stable, I thought I had
> > > been clear on this.
> >
> > I dropped the patches you asked to be dropped, but this is a different
> > one and is already in the following releases:
> > 5.10.110 5.15.33 5.16.19 5.17.2
> >
> > I can also drop it from here and the 5.4 queue if you do not want it
> > there.
> >
>
> This is not how I remember it:
>
> On Tue, 5 Apr 2022 at 18:52, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > On Tue, Apr 05, 2022 at 12:01:19PM +0200, Ard Biesheuvel wrote:
> > > On Tue, 5 Apr 2022 at 11:54, Greg Kroah-Hartman
> > > <[email protected]> wrote:
> > > >
> > > > From: Ard Biesheuvel <[email protected]>
> > > >
> > > > [ Upstream commit d11967870815b5ab89843980e35aab616c97c463 ]
> > > >
> ..
> > >
> > > Please drop all the 32-bit ARM patches authored by me from the stable
> > > queues except the ones that have fixes tags. These are highly likely
> > > to cause an explosion of regressions, and they should have never been
> > > selected, as I don't remember anyone proposing these for stable.
> >
> > From what I can tell, that is only this commit. I'll go drop it from
> > all trees, thanks.
> >
>
> Can you *please* exclude all patches authored by me from consideration
> by this bot? Consider this a blanket NAK to all AUTOSEL patches cc'ed
> to me.

Ick, I thought I dropped this from everywhere, very odd, sorry about
that. Ah, I dropped dd88b03ff0c8 ("ARM: ftrace: ensure that ADR takes
the Thumb bit into account"), not this one. {sigh}

Let me try to drop this again...

greg k-h