MSA311 is a tri-axial, low-g accelerometer with I2C digital output for
sensitivity consumer applications. It has dynamical user selectable full
scales range of +-2g/+-4g/+-8g/+-16g and allows acceleration measurements
with output data rates from 1Hz to 1000Hz.
Datasheet can be found at following URL:
https://cdn-shop.adafruit.com/product-files/5309/MSA311-V1.1-ENG.pdf
This driver supports following MSA311 features:
- IIO interface
- Different power modes: NORMAL, SUSPEND and LOW (using pm_runtime)
- ODR (Output Data Rate) selection
- Scale and samp_freq selection
- IIO triggered buffer, IIO reg access
- NEW_DATA interrupt + trigger
Below features to be done:
- Motion Events: ACTIVE, TAP, ORIENT, FREEFALL
Also this patchset has new vendor prefix for MEMSensing Microsystems and
MSA311 dt-binding schema.
You can test msa311 driver using libiio and gnuplot following below
instructions:
$ # Read 4K samples using buffer with depth equals to 64 samples and
$ # rotate device a little bit
$ iio_readdev -u "local:" -b 64 -s 4096 msa311 > /data/local/tmp/msa311.dat
$ gnuplot
gnuplot> set title "MSA311 Accel Data"
gnuplot>
gnuplot> set key below
gnuplot>
gnuplot> set xdata time
gnuplot> set format x "%H:%M\n%.4S"
gnuplot> set xlabel "timestamp"
gnuplot>
gnuplot> set autoscale y
gnuplot> plot 'msa311.dat' binary format='%int16%int16%int16%uint16%uint64'\
> using ($5/1000000000):1 title "acc_x" with lines,\
> 'msa311.dat' binary format='%int16%int16%int16%uint16%uint64' using\
> ($5/1000000000):2 title "acc_y" with lines,\
> 'msa311.dat' binary format='%int16%int16%int16%uint16%uint64' using\
> ($5/1000000000):3 title "acc_z" with lines
Dmitry Rokosov (3):
dt-bindings: vendor-prefixes: add MEMSensing Microsystems Co., Ltd.
iio: add MEMSensing MSA311 3-axis accelerometer driver
dt-bindings: iio: accel: add dt-binding schema for msa311 accel driver
.../bindings/iio/accel/memsensing,msa311.yaml | 64 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
MAINTAINERS | 7 +
drivers/iio/accel/Kconfig | 13 +
drivers/iio/accel/Makefile | 2 +
drivers/iio/accel/msa311.c | 2068 ++++++++++++++++++++
6 files changed, 2156 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
create mode 100644 drivers/iio/accel/msa311.c
--
2.9.5
Introduce devicetree binding json-schema for MSA311 tri-axial,
low-g accelerometer driver.
Signed-off-by: Dmitry Rokosov <[email protected]>
---
.../bindings/iio/accel/memsensing,msa311.yaml | 64 ++++++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 65 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
diff --git a/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
new file mode 100644
index 00000000..3e4660f
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/iio/accel/memsensing,msa311.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: MEMSensing digital 3-Axis accelerometer
+
+maintainers:
+ - Dmitry Rokosov <[email protected]>
+
+description: |
+ MSA311 is a tri-axial, low-g accelerometer with I2C digital output for
+ sensitivity consumer applications. It has dynamical user selectable full
+ scales range of +-2g/+-4g/+-8g/+-16g and allows acceleration measurements
+ with output data rates from 1Hz to 1000Hz.
+ Datasheet can be found at following URL
+ https://cdn-shop.adafruit.com/product-files/5309/MSA311-V1.1-ENG.pdf
+
+properties:
+ compatible:
+ const: memsensing,msa311
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+ reg:
+ maxItems: 1
+ description: I2C registers address
+
+ interrupts:
+ maxItems: 1
+ description: optional I2C int pin can be freely mapped to specific func
+
+ interrupt-names:
+ const: irq
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ msa311: msa311@62 {
+ compatible = "memsensing,msa311";
+ reg = <0x62>;
+ interrupt-parent = <&gpio_intc>;
+ interrupts = <29 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "irq";
+ status = "okay";
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index c75be17..4227914 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12482,6 +12482,7 @@ MEMSENSING MICROSYSTEMS MSA311 ACCELEROMETER DRIVER
M: Dmitry Rokosov <[email protected]>
L: [email protected]
S: Maintained
+F: Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
F: drivers/iio/accel/msa311.c
MEN A21 WATCHDOG DRIVER
--
2.9.5
On Tue, Apr 19, 2022 at 03:45:58PM +0000, Rokosov Dmitry Dmitrievich wrote:
> Introduce devicetree binding json-schema for MSA311 tri-axial,
> low-g accelerometer driver.
>
> Signed-off-by: Dmitry Rokosov <[email protected]>
> ---
> .../bindings/iio/accel/memsensing,msa311.yaml | 64 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
> new file mode 100644
> index 00000000..3e4660f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/iio/accel/memsensing,msa311.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: MEMSensing digital 3-Axis accelerometer
> +
> +maintainers:
> + - Dmitry Rokosov <[email protected]>
> +
> +description: |
> + MSA311 is a tri-axial, low-g accelerometer with I2C digital output for
> + sensitivity consumer applications. It has dynamical user selectable full
> + scales range of +-2g/+-4g/+-8g/+-16g and allows acceleration measurements
> + with output data rates from 1Hz to 1000Hz.
> + Datasheet can be found at following URL
> + https://cdn-shop.adafruit.com/product-files/5309/MSA311-V1.1-ENG.pdf
> +
> +properties:
> + compatible:
> + const: memsensing,msa311
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
These apply to 'reg' in a child node, but you don't have child nodes so
drop them.
> +
> + reg:
> + maxItems: 1
> + description: I2C registers address
> +
> + interrupts:
> + maxItems: 1
> + description: optional I2C int pin can be freely mapped to specific func
> +
> + interrupt-names:
> + const: irq
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c0 {
i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + msa311: msa311@62 {
accelerometer@62 {
> + compatible = "memsensing,msa311";
> + reg = <0x62>;
> + interrupt-parent = <&gpio_intc>;
> + interrupts = <29 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "irq";
> + status = "okay";
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c75be17..4227914 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12482,6 +12482,7 @@ MEMSENSING MICROSYSTEMS MSA311 ACCELEROMETER DRIVER
> M: Dmitry Rokosov <[email protected]>
> L: [email protected]
> S: Maintained
> +F: Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
> F: drivers/iio/accel/msa311.c
>
> MEN A21 WATCHDOG DRIVER
> --
> 2.9.5
>
Hi Rob,
Thank you for review! I agree with all things you mentioned. It will be
fixed in the next v2 patchset.
On Tue, Apr 26, 2022 at 03:31:05PM -0500, Rob Herring wrote:
> On Tue, Apr 19, 2022 at 03:45:58PM +0000, Rokosov Dmitry Dmitrievich wrote:
> > Introduce devicetree binding json-schema for MSA311 tri-axial,
> > low-g accelerometer driver.
> >
> > Signed-off-by: Dmitry Rokosov <[email protected]>
> > ---
> > .../bindings/iio/accel/memsensing,msa311.yaml | 64 ++++++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 65 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
> > new file mode 100644
> > index 00000000..3e4660f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/iio/accel/memsensing,msa311.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: MEMSensing digital 3-Axis accelerometer
> > +
> > +maintainers:
> > + - Dmitry Rokosov <[email protected]>
> > +
> > +description: |
> > + MSA311 is a tri-axial, low-g accelerometer with I2C digital output for
> > + sensitivity consumer applications. It has dynamical user selectable full
> > + scales range of +-2g/+-4g/+-8g/+-16g and allows acceleration measurements
> > + with output data rates from 1Hz to 1000Hz.
> > + Datasheet can be found at following URL
> > + https://cdn-shop.adafruit.com/product-files/5309/MSA311-V1.1-ENG.pdf
> > +
> > +properties:
> > + compatible:
> > + const: memsensing,msa311
> > +
>
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
>
> These apply to 'reg' in a child node, but you don't have child nodes so
> drop them.
>
Ack
> > +
> > + reg:
> > + maxItems: 1
> > + description: I2C registers address
> > +
> > + interrupts:
> > + maxItems: 1
> > + description: optional I2C int pin can be freely mapped to specific func
> > +
> > + interrupt-names:
> > + const: irq
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + i2c0 {
>
> i2c {
>
Ack
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + msa311: msa311@62 {
>
> accelerometer@62 {
>
Ack
> > + compatible = "memsensing,msa311";
> > + reg = <0x62>;
> > + interrupt-parent = <&gpio_intc>;
> > + interrupts = <29 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "irq";
> > + status = "okay";
> > + };
> > + };
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index c75be17..4227914 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -12482,6 +12482,7 @@ MEMSENSING MICROSYSTEMS MSA311 ACCELEROMETER DRIVER
> > M: Dmitry Rokosov <[email protected]>
> > L: [email protected]
> > S: Maintained
> > +F: Documentation/devicetree/bindings/iio/accel/memsensing,msa311.yaml
> > F: drivers/iio/accel/msa311.c
> >
> > MEN A21 WATCHDOG DRIVER
> > --
> > 2.9.5
> >
--
Thank you,
Dmitry
Hello Rob,
I've missed one note below, please check if possible.
On Tue, Apr 26, 2022 at 03:31:05PM -0500, Rob Herring wrote:
> On Tue, Apr 19, 2022 at 03:45:58PM +0000, Rokosov Dmitry Dmitrievich wrote:
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
>
> These apply to 'reg' in a child node, but you don't have child nodes so
> drop them.
>
I'm afraid, I made a mistake in the previous reply. Here I applied
address-cells and size-cells to show which type accelerometer's reg
property has, like this one:
i2c {
#address-cells = <1>;
#size-cells = <0>;
accelerometer@62 {
compatible = "memsensing,msa311";
reg = <0x62>;
Above accelerometer@62 is child node for i2c bus node, so address and
size cells mean accelerometer reg format. Am I missing something?
--
Thank you,
Dmitry
On Wed, 4 May 2022 18:36:33 +0000
Dmitry Rokosov <[email protected]> wrote:
> Hello Rob,
>
> I've missed one note below, please check if possible.
>
> On Tue, Apr 26, 2022 at 03:31:05PM -0500, Rob Herring wrote:
> > On Tue, Apr 19, 2022 at 03:45:58PM +0000, Rokosov Dmitry Dmitrievich wrote:
> > > + "#address-cells":
> > > + const: 1
> > > +
> > > + "#size-cells":
> > > + const: 0
> >
> > These apply to 'reg' in a child node, but you don't have child nodes so
> > drop them.
> >
>
> I'm afraid, I made a mistake in the previous reply. Here I applied
> address-cells and size-cells to show which type accelerometer's reg
> property has, like this one:
>
> i2c {
> #address-cells = <1>;
> #size-cells = <0>;
>
> accelerometer@62 {
> compatible = "memsensing,msa311";
> reg = <0x62>;
>
> Above accelerometer@62 is child node for i2c bus node, so address and
> size cells mean accelerometer reg format. Am I missing something?
They are characteristics of the i2c master and hence
are listed in those binding docs, not the one for the accelerometer.
Thanks,
Jonathan
>