2022-05-18 04:21:47

by Srivathsan Sivakumar

Subject: [PATCH] staging: rts5208: spi.c: prefer ftrace

fix the following checkpatch.pl warning:
WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by: Srivathsan Sivakumar <[email protected]>
---
drivers/staging/rts5208/spi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.c
index f1e9e80044ed..0d2d065508d3 100644
--- a/drivers/staging/rts5208/spi.c
+++ b/drivers/staging/rts5208/spi.c
@@ -460,7 +460,6 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip)
spi->clk_div = ((u16)(srb->cmnd[4]) << 8) | srb->cmnd[5];
spi->write_en = srb->cmnd[6];

- dev_dbg(rtsx_dev(chip), "%s: ", __func__);
dev_dbg(rtsx_dev(chip), "spi_clock = %d, ", spi->spi_clock);
dev_dbg(rtsx_dev(chip), "clk_div = %d, ", spi->clk_div);
dev_dbg(rtsx_dev(chip), "write_en = %d\n", spi->write_en);
--
2.34.1

2022-05-19 23:12:58

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rts5208: spi.c: prefer ftrace

On Tue, May 17, 2022 at 03:28:11PM -0400, Srivathsan Sivakumar wrote:
> fix the following checkpatch.pl warning:
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
>
> Signed-off-by: Srivathsan Sivakumar <[email protected]>
> ---
> drivers/staging/rts5208/spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/spi.c b/drivers/staging/rts5208/spi.c
> index f1e9e80044ed..0d2d065508d3 100644
> --- a/drivers/staging/rts5208/spi.c
> +++ b/drivers/staging/rts5208/spi.c
> @@ -460,7 +460,6 @@ int spi_set_parameter(struct scsi_cmnd *srb, struct rtsx_chip *chip)
> spi->clk_div = ((u16)(srb->cmnd[4]) << 8) | srb->cmnd[5];
> spi->write_en = srb->cmnd[6];
>
> - dev_dbg(rtsx_dev(chip), "%s: ", __func__);
> dev_dbg(rtsx_dev(chip), "spi_clock = %d, ", spi->spi_clock);
> dev_dbg(rtsx_dev(chip), "clk_div = %d, ", spi->clk_div);
> dev_dbg(rtsx_dev(chip), "write_en = %d\n", spi->write_en);

All three of the remaining ones should be on one line, right?

Can you fix this up and do that all at once?


thanks,

greg k-h