2022-06-06 12:38:54

by Jonathan Neuschäfer

[permalink] [raw]
Subject: [PATCH v2 RESEND] ARM: dts: nuvoton: wpcm450: Add missing aliases for serial0/serial1

Without these, /chosen/stdout-path = "serial0:115200n8", as done in
nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, does not work.

Signed-off-by: Jonathan Neuschäfer <[email protected]>
---

v2:
- mention WPCM450 in the summary
---
arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
index 93595850a4c3c..57943bf5aa4a9 100644
--- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
+++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
@@ -17,6 +17,8 @@ aliases {
gpio5 = &gpio5;
gpio6 = &gpio6;
gpio7 = &gpio7;
+ serial0 = &serial0;
+ serial1 = &serial1;
};

cpus {
--
2.35.1


2022-06-06 13:00:45

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 RESEND] ARM: dts: nuvoton: wpcm450: Add missing aliases for serial0/serial1

On 06/06/2022 14:35, Jonathan Neuschäfer wrote:
> Without these, /chosen/stdout-path = "serial0:115200n8", as done in
> nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, does not work.
>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>
> ---
>
> v2:
> - mention WPCM450 in the summary
> ---
> arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> index 93595850a4c3c..57943bf5aa4a9 100644
> --- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> +++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> @@ -17,6 +17,8 @@ aliases {
> gpio5 = &gpio5;
> gpio6 = &gpio6;
> gpio7 = &gpio7;
> + serial0 = &serial0;
> + serial1 = &serial1;

Serial aliases might be wired differently per board, so this should go
to board DTS instead.


Best regards,
Krzysztof

2022-06-06 13:06:42

by Jonathan Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH v2 RESEND] ARM: dts: nuvoton: wpcm450: Add missing aliases for serial0/serial1

On Mon, Jun 06, 2022 at 02:54:21PM +0200, Krzysztof Kozlowski wrote:
> On 06/06/2022 14:35, Jonathan Neuschäfer wrote:
> > Without these, /chosen/stdout-path = "serial0:115200n8", as done in
> > nuvoton-wpcm450-supermicro-x9sci-ln4f.dts, does not work.
> >
> > Signed-off-by: Jonathan Neuschäfer <[email protected]>
> > ---
> >
> > v2:
> > - mention WPCM450 in the summary
> > ---
> > arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> > index 93595850a4c3c..57943bf5aa4a9 100644
> > --- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> > +++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> > @@ -17,6 +17,8 @@ aliases {
> > gpio5 = &gpio5;
> > gpio6 = &gpio6;
> > gpio7 = &gpio7;
> > + serial0 = &serial0;
> > + serial1 = &serial1;
>
> Serial aliases might be wired differently per board, so this should go
> to board DTS instead.

Ok, I'll do that.


Jonathan

Attachments:
(No filename) (1.02 kB)
 signature.asc (849.00 B)
 Download all attachments