The driver never calls the disable callback, so drop the member from
the platform struct and all callbacks from the actual platform datas.
Signed-off-by: Uwe Kleine-König <[email protected]>
---
arch/arm/mach-pxa/eseries.c | 1 -
include/linux/mfd/tc6387xb.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm/mach-pxa/eseries.c b/arch/arm/mach-pxa/eseries.c
index f37c44b6139d..cb7bf6294e12 100644
--- a/arch/arm/mach-pxa/eseries.c
+++ b/arch/arm/mach-pxa/eseries.c
@@ -138,7 +138,6 @@ static void __init __maybe_unused eseries_register_clks(void)
static struct tc6387xb_platform_data e330_tc6387xb_info = {
.enable = &eseries_tmio_enable,
- .disable = &eseries_tmio_disable,
.suspend = &eseries_tmio_suspend,
.resume = &eseries_tmio_resume,
};
diff --git a/include/linux/mfd/tc6387xb.h b/include/linux/mfd/tc6387xb.h
index b4888209494a..aacf1dcc86b9 100644
--- a/include/linux/mfd/tc6387xb.h
+++ b/include/linux/mfd/tc6387xb.h
@@ -12,7 +12,6 @@
struct tc6387xb_platform_data {
int (*enable)(struct platform_device *dev);
- int (*disable)(struct platform_device *dev);
int (*suspend)(struct platform_device *dev);
int (*resume)(struct platform_device *dev);
};
--
2.36.1
On Mon, 30 May 2022, Uwe Kleine-König wrote:
> The driver never calls the disable callback, so drop the member from
> the platform struct and all callbacks from the actual platform datas.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
> ---
> arch/arm/mach-pxa/eseries.c | 1 -
> include/linux/mfd/tc6387xb.h | 1 -
> 2 files changed, 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Hello Lee,
On Wed, Jun 15, 2022 at 10:07:04PM +0100, Lee Jones wrote:
> On Mon, 30 May 2022, Uwe Kleine-K?nig wrote:
>
> > The driver never calls the disable callback, so drop the member from
> > the platform struct and all callbacks from the actual platform datas.
> >
> > Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> > ---
> > arch/arm/mach-pxa/eseries.c | 1 -
> > include/linux/mfd/tc6387xb.h | 1 -
> > 2 files changed, 2 deletions(-)
>
> Applied, thanks.
Are these already in a public tree? They are not in next and
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git#for-mfd-next
doesn't contain commits that are not in v5.19-rc1.
I assume they are still in an internal tree and I just need some
patience until they are pushed out?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
On Sun, 19 Jun 2022, Uwe Kleine-König wrote:
> Hello Lee,
>
> On Wed, Jun 15, 2022 at 10:07:04PM +0100, Lee Jones wrote:
> > On Mon, 30 May 2022, Uwe Kleine-König wrote:
> >
> > > The driver never calls the disable callback, so drop the member from
> > > the platform struct and all callbacks from the actual platform datas.
> > >
> > > Signed-off-by: Uwe Kleine-König <[email protected]>
> > > ---
> > > arch/arm/mach-pxa/eseries.c | 1 -
> > > include/linux/mfd/tc6387xb.h | 1 -
> > > 2 files changed, 2 deletions(-)
> >
> > Applied, thanks.
>
> Are these already in a public tree? They are not in next and
> git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git#for-mfd-next
> doesn't contain commits that are not in v5.19-rc1.
>
> I assume they are still in an internal tree and I just need some
> patience until they are pushed out?
Correct. Patience is a virtue.
I'm back at my desk today after a week of travel.
Check -next tomorrow.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog