2022-08-05 10:01:55

by Johan Hovold

[permalink] [raw]
Subject: [PATCH 0/7] arm64: dts: qcom: sc8280xp: HID wakeup sources and alt. touchpad

This series clean up the sc8280xp CRD and X13s HID nodes somewhat and
marks the keyboard and touchpad as wakeup sources.

Included is also support for the alternate (second-source) touchpad
found on some X13s laptops. Note that the node is disabled for now as
ideally the boot firmware should be determining which touchpad is
actually populated.

With some additional fixes it is possible to have both nodes enabled and
letting Linux do the probing, but let's wait for a conclusion to the
discussion about whether that is desirable before enabling them both:

https://lore.kernel.org/all/[email protected]

Johan


Johan Hovold (7):
arm64: dts: qcom: sc8280xp-crd: disable touchscreen pull-up
arm64: dts: qcom: sc8280xp-crd: move HID pin config
arm64: dts: qcom: sc8280xp-crd: mark HID wakeup sources
arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disable touchscreen
pull-up
arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: move HID pin config
arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: mark HID wakeup
sources
arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate
touchpad

arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 22 +++++++++--
.../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 38 +++++++++++++++++--
2 files changed, 54 insertions(+), 6 deletions(-)

--
2.35.1



2022-08-05 11:08:56

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 0/7] arm64: dts: qcom: sc8280xp: HID wakeup sources and alt. touchpad



On 5.08.2022 11:23, Johan Hovold wrote:
> This series clean up the sc8280xp CRD and X13s HID nodes somewhat and
> marks the keyboard and touchpad as wakeup sources.
>
> Included is also support for the alternate (second-source) touchpad
> found on some X13s laptops. Note that the node is disabled for now as
> ideally the boot firmware should be determining which touchpad is
> actually populated.
Interesting, what bootloader is used on these? Are you chainloading
something on top of Qualcomm's XBL UEFI?

Konrad
>
> With some additional fixes it is possible to have both nodes enabled and
> letting Linux do the probing, but let's wait for a conclusion to the
> discussion about whether that is desirable before enabling them both:
>
> https://lore.kernel.org/all/[email protected]
>
> Johan
>
>
> Johan Hovold (7):
> arm64: dts: qcom: sc8280xp-crd: disable touchscreen pull-up
> arm64: dts: qcom: sc8280xp-crd: move HID pin config
> arm64: dts: qcom: sc8280xp-crd: mark HID wakeup sources
> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disable touchscreen
> pull-up
> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: move HID pin config
> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: mark HID wakeup
> sources
> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate
> touchpad
>
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 22 +++++++++--
> .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 38 +++++++++++++++++--
> 2 files changed, 54 insertions(+), 6 deletions(-)
>

2022-08-05 12:21:35

by Johan Hovold

[permalink] [raw]
Subject: Re: [PATCH 0/7] arm64: dts: qcom: sc8280xp: HID wakeup sources and alt. touchpad

On Fri, Aug 05, 2022 at 01:02:14PM +0200, Konrad Dybcio wrote:
> On 5.08.2022 11:23, Johan Hovold wrote:

> > Included is also support for the alternate (second-source) touchpad
> > found on some X13s laptops. Note that the node is disabled for now as
> > ideally the boot firmware should be determining which touchpad is
> > actually populated.

> Interesting, what bootloader is used on these? Are you chainloading
> something on top of Qualcomm's XBL UEFI?

We're using GRUB currently. Not sure how we'd go about implementing
this, and perhaps we'll just end up enabling both in DT instead
eventually.

> > With some additional fixes it is possible to have both nodes enabled and
> > letting Linux do the probing, but let's wait for a conclusion to the
> > discussion about whether that is desirable before enabling them both:
> >
> > https://lore.kernel.org/all/[email protected]

Johan