2022-05-24 15:31:23

by Pandey, Radhey Shyam

Subject: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the coverity warning

From: Shravya Kumbham <[email protected]>

Typecast the flags variable with (enum dma_ctrl_flags) in
zynqmp_dma_prep_memcpy function to fix the coverity warning.

Addresses-Coverity: Event mixed_enum_type.
Signed-off-by: Shravya Kumbham <[email protected]>
Signed-off-by: Harini Katakam <[email protected]>
Signed-off-by: Radhey Shyam Pandey <[email protected]>
---
NOTE- This patch was sent to dmaengine mailing list[1] and
there was a suggestion from Michael Tretter to change the
signature of the dmaengine_prep_dma_memcpy() engine to accept
"enum dma_ctrl_flags flags" instead of "unsigned long flags".

All device_prep_dma_* API variants have ulong flags argument.
So this is a wider question if we want to change these APIs?
Also there are existing users of these public APIs.

[1]: https://lore.kernel.org/linux-arm-kernel/[email protected]/t/#m1d1bc959f500b04fa1470caa31239a95c73fd45d
---
drivers/dma/xilinx/zynqmp_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c
index dc299ab36818..3f4ee3954384 100644
--- a/drivers/dma/xilinx/zynqmp_dma.c
+++ b/drivers/dma/xilinx/zynqmp_dma.c
@@ -849,7 +849,7 @@ static struct dma_async_tx_descriptor *zynqmp_dma_prep_memcpy(

zynqmp_dma_desc_config_eod(chan, desc);
async_tx_ack(&first->async_tx);
- first->async_tx.flags = flags;
+ first->async_tx.flags = (enum dma_ctrl_flags)flags;
return &first->async_tx;
}

--
2.25.1

2022-07-21 14:42:13

by Pandey, Radhey Shyam

Subject: RE: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the coverity warning

> -----Original Message-----
> From: Radhey Shyam Pandey <[email protected]>
> Sent: Tuesday, May 24, 2022 1:19 PM
> To: [email protected]; Michal Simek <[email protected]>;
> [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; Shravya Kumbham <[email protected]>; Harini
> Katakam <[email protected]>; Radhey Shyam Pandey
> <[email protected]>
> Subject: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the
> coverity warning
>
> From: Shravya Kumbham <[email protected]>
>
> Typecast the flags variable with (enum dma_ctrl_flags) in
> zynqmp_dma_prep_memcpy function to fix the coverity warning.
>
> Addresses-Coverity: Event mixed_enum_type.
> Signed-off-by: Shravya Kumbham <[email protected]>
> Signed-off-by: Harini Katakam <[email protected]>
> Signed-off-by: Radhey Shyam Pandey <[email protected]>
> ---
> NOTE- This patch was sent to dmaengine mailing list[1] and
> there was a suggestion from Michael Tretter to change the
> signature of the dmaengine_prep_dma_memcpy() engine to accept
> "enum dma_ctrl_flags flags" instead of "unsigned long flags".
>
> All device_prep_dma_* API variants have ulong flags argument.
> So this is a wider question if we want to change these APIs?
> Also there are existing users of these public APIs.
>
> [1]: https://lore.kernel.org/linux-arm-kernel/20210914082817.22311-2-
> [email protected]/t/#m1d1bc959f500b04fa1470caa31239a95c73fd
> 45d
> ---
> drivers/dma/xilinx/zynqmp_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/zynqmp_dma.c
> b/drivers/dma/xilinx/zynqmp_dma.c
> index dc299ab36818..3f4ee3954384 100644
> --- a/drivers/dma/xilinx/zynqmp_dma.c
> +++ b/drivers/dma/xilinx/zynqmp_dma.c
> @@ -849,7 +849,7 @@ static struct dma_async_tx_descriptor
> *zynqmp_dma_prep_memcpy(
>
> zynqmp_dma_desc_config_eod(chan, desc);
> async_tx_ack(&first->async_tx);
> - first->async_tx.flags = flags;
> + first->async_tx.flags = (enum dma_ctrl_flags)flags;
> return &first->async_tx;
> }
>
> --
Ping! for review.

2022-09-05 06:33:01

by Vinod Koul

Subject: Re: [PATCH] dmaengine: zynqmp_dma: Typecast with enum to fix the coverity warning

On 24-05-22, 13:19, Radhey Shyam Pandey wrote:
> From: Shravya Kumbham <[email protected]>
>
> Typecast the flags variable with (enum dma_ctrl_flags) in
> zynqmp_dma_prep_memcpy function to fix the coverity warning.

Applied, thanks

>
> Addresses-Coverity: Event mixed_enum_type.
> Signed-off-by: Shravya Kumbham <[email protected]>
> Signed-off-by: Harini Katakam <[email protected]>
> Signed-off-by: Radhey Shyam Pandey <[email protected]>
> ---
> NOTE- This patch was sent to dmaengine mailing list[1] and
> there was a suggestion from Michael Tretter to change the
> signature of the dmaengine_prep_dma_memcpy() engine to accept
> "enum dma_ctrl_flags flags" instead of "unsigned long flags".
>
> All device_prep_dma_* API variants have ulong flags argument.
> So this is a wider question if we want to change these APIs?
> Also there are existing users of these public APIs.

It would be very nice to do this change but users would need to be
updated as well, patches are welcome

--
~Vinod