2022-09-06 21:36:14

by Gustavo A. R. Silva

Subject: [PATCH][next] powerpc: Fix fall-through warning for Clang

Fix the following fallthrough warning:

arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

Link: https://github.com/KSPP/linux/issues/198
Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/lkml/[email protected]/
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
arch/powerpc/platforms/85xx/mpc85xx_cds.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/85xx/mpc85xx_cds.c b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
index 48f3acfece0b..0b8f2101c5fb 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_cds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_cds.c
@@ -159,6 +159,7 @@ static void __init mpc85xx_cds_pci_irq_fixup(struct pci_dev *dev)
else
dev->irq = 10;
pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq);
+ break;
default:
break;
}
--
2.34.1

2022-09-08 00:27:05

by Kees Cook

Subject: Re: [PATCH][next] powerpc: Fix fall-through warning for Clang

On Tue, Sep 06, 2022 at 10:32:13PM +0100, Gustavo A. R. Silva wrote:
> Fix the following fallthrough warning:
>
> arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>
> Link: https://github.com/KSPP/linux/issues/198
> Reported-by: kernel test robot <[email protected]>
> Link: https://lore.kernel.org/lkml/[email protected]/
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Thanks!

Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook

2022-09-23 11:23:17

by Michael Ellerman

Subject: Re: [PATCH][next] powerpc: Fix fall-through warning for Clang

On Tue, 6 Sep 2022 22:32:13 +0100, Gustavo A. R. Silva wrote:
> Fix the following fallthrough warning:
>
> arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>
>

Applied to powerpc/next.

[1/1] powerpc: Fix fall-through warning for Clang
https://git.kernel.org/powerpc/c/d4d944ff68cb1f896d3f3b1af0bc656949dc626a

cheers

2022-09-23 17:13:31

by Gustavo A. R. Silva

Subject: Re: [PATCH][next] powerpc: Fix fall-through warning for Clang

> Applied to powerpc/next.

Great. :)

Thanks, Michael.
--
Gustavo