2022-09-07 04:19:25

by Jiapeng Chong

Subject: [PATCH] cgroup/cpuset: remove unreachable code

The function sched_partition_show cannot execute seq_puts, delete the
invalid code.

kernel/cgroup/cpuset.c:2849 sched_partition_show() warn: ignoring unreachable code.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2087
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
kernel/cgroup/cpuset.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 6baa977a71ba..b474289c15b8 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -2846,8 +2846,6 @@ static int sched_partition_show(struct seq_file *seq, void *v)
else
seq_printf(seq, "%s invalid\n", type);
break;
- seq_puts(seq, "isolated invalid\n");
- break;
}
return 0;
}
--
2.20.1.7.g153144c

2022-09-07 15:38:41

by Tejun Heo

Subject: Re: [PATCH] cgroup/cpuset: remove unreachable code

(cc'ing Waiman and quoting the whole message)

On Wed, Sep 07, 2022 at 12:01:12PM +0800, Jiapeng Chong wrote:
> The function sched_partition_show cannot execute seq_puts, delete the
> invalid code.
>
> kernel/cgroup/cpuset.c:2849 sched_partition_show() warn: ignoring unreachable code.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2087
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---

Applied to cgroup/for-6.1.

Thanks.

> kernel/cgroup/cpuset.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 6baa977a71ba..b474289c15b8 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -2846,8 +2846,6 @@ static int sched_partition_show(struct seq_file *seq, void *v)
> else
> seq_printf(seq, "%s invalid\n", type);
> break;
> - seq_puts(seq, "isolated invalid\n");
> - break;
> }
> return 0;
> }
> --
> 2.20.1.7.g153144c
>

--
tejun