2022-09-21 09:47:09

by CGEL

Subject: [PATCH linux-next] cgroup: use strscpy() is more robust and safer

From: ye xingchen <[email protected]>

The implementation of strscpy() is more robust and safer.

That's now the recommended way to copy NUL terminated strings.

Signed-off-by: ye xingchen <[email protected]>
---
kernel/cgroup/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 829aa42e773e..48a8e8fb3e91 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2374,7 +2374,7 @@ int task_cgroup_path(struct task_struct *task, char *buf, size_t buflen)
ret = cgroup_path_ns_locked(cgrp, buf, buflen, &init_cgroup_ns);
} else {
/* if no hierarchy exists, everyone is in "/" */
- ret = strlcpy(buf, "/", buflen);
+ ret = strscpy(buf, "/", buflen);
}

spin_unlock_irq(&css_set_lock);
--
2.25.1

2022-09-24 03:53:39

by Tejun Heo

Subject: Re: [PATCH linux-next] cgroup: use strscpy() is more robust and safer

On Wed, Sep 21, 2022 at 09:35:17AM +0000, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> The implementation of strscpy() is more robust and safer.
>
> That's now the recommended way to copy NUL terminated strings.
>
> Signed-off-by: ye xingchen <[email protected]>

Applied to cgroup/for-6.1.

Thanks.

--
tejun