Hi all,
After merging the bitmap tree, today's linux-next build (x86
allmodconfig) failed like this:
In file included from /tmp/next/build/include/linux/printk.h:573,
from /tmp/next/build/include/linux/kernel.h:29,
from /tmp/next/build/arch/x86/include/asm/percpu.h:27,
from /tmp/next/build/arch/x86/include/asm/nospec-branch.h:14,
from /tmp/next/build/arch/x86/include/asm/paravirt_types.h:40,
from /tmp/next/build/arch/x86/include/asm/ptrace.h:97,
from /tmp/next/build/arch/x86/include/asm/math_emu.h:5,
from /tmp/next/build/arch/x86/include/asm/processor.h:13,
from /tmp/next/build/arch/x86/include/asm/timex.h:5,
from /tmp/next/build/include/linux/timex.h:67,
from /tmp/next/build/include/linux/time32.h:13,
from /tmp/next/build/include/linux/time.h:60,
from /tmp/next/build/include/linux/stat.h:19,
from /tmp/next/build/include/linux/module.h:13,
from /tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:9:
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c: In function 'rvu_npc_exact_alloc_mem_table_entry':
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:454:20: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format=]
454 | dev_dbg(rvu->dev, "%s: No space in 4 way exact way, weight=%lu\n", __func__,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dynamic_debug.h:223:15: note: in definition of macro '__dynamic_func_call_cls'
223 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
/tmp/next/build/include/linux/dynamic_debug.h:249:2: note: in expansion of macro '_dynamic_func_call_cls'
249 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dynamic_debug.h:272:2: note: in expansion of macro '_dynamic_func_call'
272 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:155:2: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:155:23: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:454:2: note: in expansion of macro 'dev_dbg'
454 | dev_dbg(rvu->dev, "%s: No space in 4 way exact way, weight=%lu\n", __func__,
| ^~~~~~~
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:454:63: note: format string is defined here
454 | dev_dbg(rvu->dev, "%s: No space in 4 way exact way, weight=%lu\n", __func__,
| ~~^
| |
| long unsigned int
| %u
In file included from /tmp/next/build/include/linux/device.h:15,
from /tmp/next/build/include/linux/pci.h:37,
from /tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:10:
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c: In function 'rvu_npc_exact_alloc_id':
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:492:21: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=]
492 | dev_err(rvu->dev, "%s: No space in id bitmap (%lu)\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
/tmp/next/build/include/linux/dev_printk.h:144:49: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:492:3: note: in expansion of macro 'dev_err'
492 | dev_err(rvu->dev, "%s: No space in id bitmap (%lu)\n",
| ^~~~~~~
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:492:51: note: format string is defined here
492 | dev_err(rvu->dev, "%s: No space in id bitmap (%lu)\n",
| ~~^
| |
| long unsigned int
| %u
In file included from /tmp/next/build/include/linux/device.h:15,
from /tmp/next/build/include/linux/pci.h:37,
from /tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:10:
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c: In function 'rvu_npc_exact_alloc_cam_table_entry':
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:525:22: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=]
525 | dev_info(rvu->dev, "%s: No space in exact cam table, weight=%lu\n", __func__,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
/tmp/next/build/include/linux/dev_printk.h:150:51: note: in expansion of macro 'dev_fmt'
150 | dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:525:3: note: in expansion of macro 'dev_info'
525 | dev_info(rvu->dev, "%s: No space in exact cam table, weight=%lu\n", __func__,
| ^~~~~~~~
/tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:525:65: note: format string is defined here
525 | dev_info(rvu->dev, "%s: No space in exact cam table, weight=%lu\n", __func__,
| ~~^
| |
| long unsigned int
| %u
cc1: all warnings being treated as errors
make[8]: *** [/tmp/next/build/scripts/Makefile.build:249: drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.o] Error 1
make[7]: *** [/tmp/next/build/scripts/Makefile.build:440: drivers/net/ethernet/marvell/octeontx2/af] Error 2
make[6]: *** [/tmp/next/build/scripts/Makefile.build:440: drivers/net/ethernet/marvell/octeontx2] Error 2
make[5]: *** [/tmp/next/build/scripts/Makefile.build:440: drivers/net/ethernet/marvell] Error 2
make[5]: *** Waiting for unfinished jobs....
/tmp/next/build/drivers/gpu/drm/i915/gt/intel_sseu.c: In function 'intel_sseu_print_ss_info':
/tmp/next/build/drivers/gpu/drm/i915/gt/intel_sseu.c:867:39: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=]
867 | seq_printf(m, " %s Geometry DSS: %lu\n", type,
| ~~^
| |
| long unsigned int
| %u
868 | bitmap_weight(sseu->geometry_subslice_mask.xehp,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| unsigned int
869 | XEHP_BITMAP_BITS(sseu->geometry_subslice_mask)));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/drivers/gpu/drm/i915/gt/intel_sseu.c:870:38: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=]
870 | seq_printf(m, " %s Compute DSS: %lu\n", type,
| ~~^
| |
| long unsigned int
| %u
871 | bitmap_weight(sseu->compute_subslice_mask.xehp,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| unsigned int
872 | XEHP_BITMAP_BITS(sseu->compute_subslice_mask)));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
These look like they have probably been there for a while but I've used
a slightly different compiler version to Stephen so they're showing up
now once the bitmap tree is merged. I will have a proper look tomorrow
hopefully but for now I've dropped the bitmap tree as it's getting very
late and it is likely I'll not finish the -next run today at all.
On Tue, Sep 27, 2022 at 12:53:48AM +0100, [email protected] wrote:
> Hi all,
>
> After merging the bitmap tree, today's linux-next build (x86
> allmodconfig) failed like this:
Hmm, this weird. I checked the next-20220923, and the drivers' code
mentioned in the log differs from what I see, and looks correct.
bitmap_weight() definition hasn't been changed in bitmap-for-next
patches.
Allmodconfig build looks good to me.
Check what I see in next-20220923 below.
Thanks,
Yury
> /tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:492:3: note: in expansion of macro 'dev_err'
> 492 | dev_err(rvu->dev, "%s: No space in id bitmap (%lu)\n",
> | ^~~~~~~
> /tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:492:51: note: format string is defined here
> 492 | dev_err(rvu->dev, "%s: No space in id bitmap (%lu)\n",
> | ~~^
> | |
> | long unsigned int
> | %u
dev_err(rvu->dev, "%s: No space in id bitmap (%d)\n",
__func__, bitmap_weight(table->id_bmap, table->tot_ids));
> /tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:525:22: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=]
> 525 | dev_info(rvu->dev, "%s: No space in exact cam table, weight=%lu\n", __func__,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dev_info(rvu->dev, "%s: No space in exact cam table, weight=%u\n", __func__,
bitmap_weight(table->cam_table.bmap, table->cam_table.depth));jj
> /tmp/next/build/drivers/gpu/drm/i915/gt/intel_sseu.c:867:39: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=]
> 867 | seq_printf(m, " %s Geometry DSS: %lu\n", type,
> | ~~^
> | |
> | long unsigned int
> | %u
> 868 | bitmap_weight(sseu->geometry_subslice_mask.xehp,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | unsigned int
> 869 | XEHP_BITMAP_BITS(sseu->geometry_subslice_mask)));
seq_printf(m, " %s Geometry DSS: %u\n", type,
bitmap_weight(sseu->geometry_subslice_mask.xehp,
XEHP_BITMAP_BITS(sseu->geometry_subslice_mask)));
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/next/build/drivers/gpu/drm/i915/gt/intel_sseu.c:870:38: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=]
> 870 | seq_printf(m, " %s Compute DSS: %lu\n", type,
> | ~~^
> | |
> | long unsigned int
> | %u
> 871 | bitmap_weight(sseu->compute_subslice_mask.xehp,
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | |
> | unsigned int
> 872 | XEHP_BITMAP_BITS(sseu->compute_subslice_mask)));
bitmap_weight(sseu->compute_subslice_mask.xehp,
XEHP_BITMAP_BITS(sseu->compute_subslice_mask)));
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> These look like they have probably been there for a while but I've used
> a slightly different compiler version to Stephen so they're showing up
> now once the bitmap tree is merged. I will have a proper look tomorrow
> hopefully but for now I've dropped the bitmap tree as it's getting very
> late and it is likely I'll not finish the -next run today at all.
On Mon, Sep 26, 2022 at 05:37:46PM -0700, Yury Norov wrote:
> On Tue, Sep 27, 2022 at 12:53:48AM +0100, [email protected] wrote:
> > After merging the bitmap tree, today's linux-next build (x86
> > allmodconfig) failed like this:
> Hmm, this weird. I checked the next-20220923, and the drivers' code
> mentioned in the log differs from what I see, and looks correct.
> bitmap_weight() definition hasn't been changed in bitmap-for-next
> patches.
> Allmodconfig build looks good to me.
> Check what I see in next-20220923 below.
I'm seeing the same issue again today, the driver hasn't changed here -
the
> > /tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:492:3: note: in expansion of macro 'dev_err'
> > 492 | dev_err(rvu->dev, "%s: No space in id bitmap (%lu)\n",
> > | ^~~~~~~
> > /tmp/next/build/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:492:51: note: format string is defined here
> > 492 | dev_err(rvu->dev, "%s: No space in id bitmap (%lu)\n",
> > | ~~^
> > | |
> > | long unsigned int
> > | %u
> dev_err(rvu->dev, "%s: No space in id bitmap (%d)\n",
> __func__, bitmap_weight(table->id_bmap, table->tot_ids));
This is coming from a patch Stephen had in his tree "fix up for
bitmap_weight return value changing" which had been in -next, apparently
fixing some other issue which had been in your tree. With that removed
things seem fine.