2022-09-27 19:57:01

by Wolfram Sang

[permalink] [raw]

Subject: Re: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC

---

> + ret = mlxbf_i2c_init_resource(pdev, &priv->smbus,
> + MLXBF_I2C_SMBUS_RES);

Did you maybe forget to check 'ret' here?

> + priv->timer->io = priv->smbus->io;
> + priv->mst->io = priv->smbus->io + MLXBF_I2C_MST_ADDR_OFFSET;
> + priv->slv->io = priv->smbus->io + MLXBF_I2C_SLV_ADDR_OFFSET;

---

Attachments:

(No filename) (319.00 B)
signature.asc (849.00 B)
Download all attachments

2022-09-27 19:59:24

by Asmaa Mnebhi

[permalink] [raw]

Subject: RE: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC

---

> + ret = mlxbf_i2c_init_resource(pdev, &priv->smbus,
> + MLXBF_I2C_SMBUS_RES);

Did you maybe forget to check 'ret' here?

Yes will do!
> + priv->timer->io = priv->smbus->io;
> + priv->mst->io = priv->smbus->io + MLXBF_I2C_MST_ADDR_OFFSET;
> + priv->slv->io = priv->smbus->io + MLXBF_I2C_SLV_ADDR_OFFSET;