2023-07-07 13:17:34

by Mike Looijmans

Subject: [PATCH v2 1/2] dt-bindings: Input: exc3000 - Support power supply regulators

Add power supply regulator support to the exc3000 devices.

Signed-off-by: Mike Looijmans <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>

---

(no changes since v1)

.../devicetree/bindings/input/touchscreen/eeti,exc3000.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
index 007adbc89c14..9dc25d30a0a8 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
@@ -24,6 +24,8 @@ properties:
maxItems: 1
reset-gpios:
maxItems: 1
+ vdd-supply:
+ description: Power supply regulator for the chip
touchscreen-size-x: true
touchscreen-size-y: true
touchscreen-inverted-x: true
--
2.17.1


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: http://www.topic.nl

Please consider the environment before printing this e-mail

2023-07-07 13:18:25

by Mike Looijmans

Subject: [PATCH v2 2/2] Input: exc3000 - Support power supply regulators

Add power supply regulator support to the exc3000 devices.

Signed-off-by: Mike Looijmans <[email protected]>

---

Changes in v2:
Add missing "return" statement
Use devm_regulator_get_enable without _optional

drivers/input/touchscreen/exc3000.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c
index 4af4c1e5d0da..e3f6d21b3c1b 100644
--- a/drivers/input/touchscreen/exc3000.c
+++ b/drivers/input/touchscreen/exc3000.c
@@ -18,6 +18,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of.h>
+#include <linux/regulator/consumer.h>
#include <linux/sizes.h>
#include <linux/timer.h>
#include <asm/unaligned.h>
@@ -360,6 +361,12 @@ static int exc3000_probe(struct i2c_client *client)
if (IS_ERR(data->reset))
return PTR_ERR(data->reset);

+ /* For proper reset sequence, enable power while reset asserted */
+ error = devm_regulator_get_enable(&client->dev, "vdd");
+ if (error && error != -ENODEV)
+ return dev_err_probe(&client->dev, error,
+ "failed to request vdd regulator\n");
+
if (data->reset) {
msleep(EXC3000_RESET_MS);
gpiod_set_value_cansleep(data->reset, 0);
--
2.17.1


Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert


TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: http://www.topic.nl

Please consider the environment before printing this e-mail

2023-07-08 00:06:43

by Dmitry Torokhov

Subject: Re: [PATCH v2 2/2] Input: exc3000 - Support power supply regulators

On Fri, Jul 07, 2023 at 03:10:42PM +0200, Mike Looijmans wrote:
> Add power supply regulator support to the exc3000 devices.
>
> Signed-off-by: Mike Looijmans <[email protected]>
>

Applied, thank you.

--
Dmitry

2023-07-08 00:06:43

by Dmitry Torokhov

Subject: Re: [PATCH v2 1/2] dt-bindings: Input: exc3000 - Support power supply regulators

On Fri, Jul 07, 2023 at 03:10:41PM +0200, Mike Looijmans wrote:
> Add power supply regulator support to the exc3000 devices.
>
> Signed-off-by: Mike Looijmans <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
>

Applied, thank you.

--
Dmitry