2023-09-07 17:49:10

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: [RFC PATCH net-next 1/7] net: phy: introduce phy numbering and phy namespaces

On Thu, Sep 07, 2023 at 11:23:59AM +0200, Maxime Chevallier wrote:
> @@ -640,6 +642,7 @@ struct phy_device {
>
> struct device_link *devlink;
>
> + int phyindex;
> u32 phy_id;
>
> struct phy_c45_device_ids c45_ids;
> @@ -761,6 +764,7 @@ struct phy_device {
> /* MACsec management functions */
> const struct macsec_ops *macsec_ops;
> #endif
> + struct list_head node;

I haven't yet fully looked at this, but the one thing that did stand out
was this - please name it "phy_ns_node" so that the purpose of this node
is clear.

Thanks.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!