2023-09-07 18:03:17

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: [RFC PATCH net-next 6/7] net: ethtool: add a netlink command to get PHY information

On Thu, Sep 07, 2023 at 11:24:04AM +0200, Maxime Chevallier wrote:
> + data->phyindex = req_info->phyindex;
> + data->drvname = phydev->drv->name;
> + if (phydev->is_on_sfp_module)

Please use the accessor provided:

if (phy_on_sfp(phydev))

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!